Skip to content

feat: Measure performance of resolution and shader compilation#1441

Merged
iwoplaza merged 15 commits intomainfrom
feat/perf-measure
Jul 4, 2025
Merged

feat: Measure performance of resolution and shader compilation#1441
iwoplaza merged 15 commits intomainfrom
feat/perf-measure

Conversation

@iwoplaza
Copy link
Collaborator

@iwoplaza iwoplaza commented Jul 1, 2025

Screen.Recording.2025-07-03.at.19.42.21.mov

Benchmark results as generated HTML & JSON:

image

@github-actions
Copy link

github-actions bot commented Jul 1, 2025

pkg.pr.new

packages

pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@1441
pnpm i https://pkg.pr.new/software-mansion/TypeGPU/typegpu@568e96330594523a36d90b4f5667e8bb9b0e2ad8

benchmark
view benchmark

commit
view commit

@iwoplaza iwoplaza marked this pull request as ready for review July 3, 2025 17:49
@aleksanderkatan
Copy link
Contributor

I get an error when running the tests, any ideas?

image

@iwoplaza
Copy link
Collaborator Author

iwoplaza commented Jul 4, 2025

I get an error when running the tests, any ideas?

image

Yes, the dev server has to be running during the test, for assets 👀

@aleksanderkatan
Copy link
Contributor

Yes, the dev server has to be running during the test, for assets 👀

Ofc, my bad

Copy link
Contributor

@reczkok reczkok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing addition! No more manual clicking 🙇‍♂️

@iwoplaza iwoplaza merged commit 732a7a5 into main Jul 4, 2025
6 checks passed
@iwoplaza iwoplaza deleted the feat/perf-measure branch July 4, 2025 10:20
Copy link
Contributor

@aleksanderkatan aleksanderkatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, super useful!

*/
const timeout = 120 * 1000;

const iterations = 10;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make it a little smaller, or could we make the number of iterations passable via the command line?

* The amount of time after Vitest decides that the test
* has gone rogue. Adjust as necessary.
*/
const timeout = 120 * 1000;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this timeout may be a little to close to how long the test actually takes, it actually timed out on me once even though there was no lag nor wait for camera permission. Can we also make it depend on the number of iterations?

@iwoplaza iwoplaza linked an issue Jul 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fear: Experiment with using Playwright for end-to-end local testing

3 participants