feat: Measure performance of resolution and shader compilation#1441
Merged
feat: Measure performance of resolution and shader compilation#1441
Conversation
|
pkg.pr.new packages benchmark commit |
Contributor
Collaborator
Author
Contributor
Ofc, my bad |
reczkok
approved these changes
Jul 4, 2025
Contributor
reczkok
left a comment
There was a problem hiding this comment.
Amazing addition! No more manual clicking 🙇♂️
apps/typegpu-docs/src/content/examples/simulation/fluid-with-atomics/index.ts
Show resolved
Hide resolved
Contributor
aleksanderkatan
left a comment
There was a problem hiding this comment.
Great job, super useful!
apps/typegpu-docs/src/content/examples/simulation/fluid-with-atomics/index.ts
Show resolved
Hide resolved
| */ | ||
| const timeout = 120 * 1000; | ||
|
|
||
| const iterations = 10; |
Contributor
There was a problem hiding this comment.
Could we make it a little smaller, or could we make the number of iterations passable via the command line?
| * The amount of time after Vitest decides that the test | ||
| * has gone rogue. Adjust as necessary. | ||
| */ | ||
| const timeout = 120 * 1000; |
Contributor
There was a problem hiding this comment.
I think this timeout may be a little to close to how long the test actually takes, it actually timed out on me once even though there was no lag nor wait for camera permission. Can we also make it depend on the number of iterations?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Screen.Recording.2025-07-03.at.19.42.21.mov
Benchmark results as generated HTML & JSON: