Conversation
|
pkg.pr.new packages benchmark commit |
deluksic
reviewed
Jun 30, 2025
apps/typegpu-docs/src/content/examples/rendering/ray-marching/index.ts
Outdated
Show resolved
Hide resolved
iwoplaza
requested review from
aleksanderkatan,
deluksic and
reczkok
and removed request for
deluksic
deluksic
reviewed
Jun 30, 2025
deluksic
approved these changes
Jun 30, 2025
reczkok
reviewed
Jul 1, 2025
reczkok
requested changes
Jul 4, 2025
reczkok
approved these changes
Jul 4, 2025
apps/typegpu-docs/src/content/examples/rendering/ray-marching/index.ts
Outdated
Show resolved
Hide resolved
| const resolution = root.createUniform(d.vec2f); | ||
|
|
||
| const MAX_STEPS = 1000; | ||
| const MAX_DIST = 500; |
Contributor
There was a problem hiding this comment.
I think we can reduce it to something like 20 - anything beyond that is just aliased checkerboard. I also like the "small planet" appearance this gives along with performance benefits.
| Version | Visual Output | Performance Logs |
|---|---|---|
| Before |  |
 |
| After |  |
 |
Collaborator
Author
There was a problem hiding this comment.
Nice! The spherical world effect messes with my head a bit though, since the checkerboard is not distorted to go around a spherical world. What if we added a fog instead?
Screen.Recording.2025-07-04.at.15.58.25.mov
Contributor
There was a problem hiding this comment.
if you're not aware of this masterpiece, highly recommend reading https://iquilezles.org/articles/checkerfiltering/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.