Remove test_logger feature#9125
Merged
Merged
Conversation
chong-he
added
test improvement
| } | ||
| ``` | ||
|
|
||
| ### test_logger |
Member
There was a problem hiding this comment.
Maybe we could add some docs here about how to use the new logger. Does the EnvFilter let us control the log level for different components, etc?
It might be nice to even filter out dependency logs by default? (I know the HTTP crates are quite noisy)
Member
Author
There was a problem hiding this comment.
I made some revision to the doc, and we can use the RUST_LOG environment variable to control the log level. The default is debug but we can change it with RUST_LOG=info, tested and it's working
michaelsproul
added
ready-for-merge
Merge Queue Status
This pull request spent 30 minutes 57 seconds in the queue, including 28 minutes 16 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
test_logger#9107Proposed Changes
Remove all instances of
test_loggerin the codeAdditional Info
Running with, e.g.:
cargo test --release -p beacon_chain- no beacon node logs are printedcargo test --release -p beacon_chain -- --nocapture- beacon node logs are printed