Fix duplicate data columns in DataColumnsByRange responses#8843
Merged
mergify[bot] merged 5 commits intoFeb 18, 2026
Merged
Conversation
Member
|
@jimmygchen Just needs a cargo fmt |
Member
Author
|
Thanks @michaelsproul! We really should merge this lol |
This comment was marked as outdated.
This comment was marked as outdated.
mergify
Bot
added
waiting-on-author
jimmygchen
added
ready-for-review
michaelsproul
approved these changes
Feb 18, 2026
michaelsproul
left a comment
michaelsproul
left a comment
Member
There was a problem hiding this comment.
Looks good. Test logic makes sense (request 1 column over a range of slots -> block roots should be unique).
michaelsproul
added
ready-for-merge
Merge Queue StatusRule:
This pull request spent 37 minutes 22 seconds in the queue, including 31 minutes 14 seconds running CI. Required conditions to merge
|
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix a regression introduced in #8682 where
get_block_roots_from_storereturns duplicate block roots for skip slots, causing duplicate data columns to be served inDataColumnsByRangeresponses. Peers receiving these duplicates downscore the node withDuplicatedDataerrors.The return type was changed from
Vec<Hash256>toVec<(Hash256, Slot)>, but.unique()on tuples no longer deduplicates correctly because skip slots share the same block root but have different slots. Fix by using.unique_by(|(root, _)| *root).Closes #8842