Call beacon_committee_selections only once per epoch#8699
Merged
Conversation
chong-he
added
val-client
KaloyanTanev
approved these changes
Jan 27, 2026
Member
|
lgtm! |
6 tasks
| let epoch = duties | ||
| .first() | ||
| .map(|attester_data| attester_data.slot.epoch(S::E::slots_per_epoch())) | ||
| .unwrap_or_default(); |
Member
There was a problem hiding this comment.
This should probably be an error (we should always have at least one duty).
Member
There was a problem hiding this comment.
Happy to leave as-is though.
michaelsproul
approved these changes
Jan 29, 2026
michaelsproul
left a comment
michaelsproul
left a comment
Member
There was a problem hiding this comment.
Looks good to me, I'm confident this doesn't affect the non-DVT codepath, and the logic for selections (Obol) looks correct.
michaelsproul
added
ready-for-merge
Merge Queue Status✅ The pull request has been merged at 25d3b7c This pull request spent 39 minutes 3 seconds in the queue, including 37 minutes 43 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Proposed Changes
Add another if in the if/else branch for selections_endpoint case, and leaving the current code for non-selections_endpoint case mostly untouched. Now the if/else branch in
fill_in_selection_proofshas 3 branches:Tested and it's working, also thanks very much to @KaloyanTanev for helping to test and confirmed that the calling has reduced and aggregated attestations are still working