Skip to content

Delete PartialBeaconState#8591

Merged
mergify[bot] merged 3 commits into
sigp:unstablefrom
michaelsproul:delete-partial-beacon-state
Dec 16, 2025
Merged

Delete PartialBeaconState#8591
mergify[bot] merged 3 commits into
sigp:unstablefrom
michaelsproul:delete-partial-beacon-state

Conversation

@michaelsproul

@michaelsproul michaelsproul commented Dec 16, 2025

Copy link
Copy Markdown
Member

Proposed Changes

While reviewing Gloas I noticed we were updating PartialBeaconState. This code isn't used since v7.1.0 introduced hdiffs, so we can delete it and stop maintaining it 🎉

Similarly the chunked_vector/chunked_iter code can also go!

@michaelsproul michaelsproul added ready-for-review The code is ready for review code-quality low-hanging-fruit Easy to resolve, get it before someone else does! database labels Dec 16, 2025

@pawanjay176 pawanjay176 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My favourite kind of PR 🚀
Looks like you have caught all references to the PartialBeaconState. LGTM

@mergify

mergify Bot commented Dec 16, 2025

Copy link
Copy Markdown

This pull request has merge conflicts. Could you please resolve them @michaelsproul? 🙏

@mergify mergify Bot added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Dec 16, 2025
@pawanjay176 pawanjay176 added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Dec 16, 2025
@mergify mergify Bot added the queued label Dec 16, 2025
@mergify

mergify Bot commented Dec 16, 2025

Copy link
Copy Markdown

Merge Queue Status

✅ The pull request has been merged at c435816

This pull request spent 38 minutes 36 seconds in the queue, including 37 minutes 18 seconds running CI.
The checks were run on draft #8594.

Required conditions to merge
  • check-success=local-testnet-success
  • check-success=test-suite-success

mergify Bot added a commit that referenced this pull request Dec 16, 2025
@mergify mergify Bot merged commit 4c268bc into sigp:unstable Dec 16, 2025
36 checks passed
@mergify mergify Bot removed the queued label Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code-quality database low-hanging-fruit Easy to resolve, get it before someone else does! ready-for-merge This PR is ready to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants