Skip to content

Implement /eth/v1/beacon/blobs endpoint#8103

Merged
mergify[bot] merged 26 commits into
sigp:unstablefrom
chong-he:implement-getBlobs
Oct 9, 2025
Merged

Implement /eth/v1/beacon/blobs endpoint#8103
mergify[bot] merged 26 commits into
sigp:unstablefrom
chong-he:implement-getBlobs

Conversation

@chong-he

@chong-he chong-he commented Sep 23, 2025

Copy link
Copy Markdown
Member

Issue Addressed

Proposed change

Rename current blob_sidecars endpoint from get_blobs to get_blob_sidecars to "give way" to the new get blobs endpoint. I thought this is the better way to have this new get_blobs endpoint name it this way in the code, but I am happy to change if that's not suitable/confusing

Additional Info

Testing results:

Query with:
curl -X 'GET' 'http://localhost:5052/eth/v1/beacon/blobs/12647385' | jq

Response:

{
  "execution_optimistic": true,
  "finalized": true,
  "data": [
    "blob1"
    "blob2"
    "blob3" 
    "and so on"
  ]
}

Query with versioned_hashes:
curl -X 'GET' \ 'http://localhost:5052/eth/v1/beacon/blobs/12647385?versioned_hashes=0x01171d78b2bd7cf3c3e458f7337f37272bfe6972cdd07b6e12f399a94ff6627c&versioned_hashes=0x011384275182442b69831cc581de3b80fe60b13a8efd870f8b680422087b960e' \ -H 'accept: application/json' | jq

Response:

{
  "execution_optimistic": true,
  "finalized": true,
  "data": [
      "blob1"
      "blob2"
  ]
}

chong-he
chong-he commented Sep 23, 2025
View reviewed changes
Comment thread beacon_node/http_api/src/block_id.rs
Comment thread beacon_node/http_api/src/lib.rs Outdated
Comment thread beacon_node/http_api/src/lib.rs
Comment thread consensus/types/src/beacon_response.rs
@chong-he chong-he added ready-for-review The code is ready for review HTTP-API v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky labels Sep 23, 2025
jimmygchen
jimmygchen reviewed Sep 23, 2025
View reviewed changes
Comment thread testing/simulator/src/checks.rs Outdated
jimmygchen
jimmygchen reviewed Sep 23, 2025
View reviewed changes
Comment thread lcli/src/http_sync.rs
jimmygchen
jimmygchen reviewed Sep 23, 2025
View reviewed changes
Comment thread common/eth2/src/lib.rs
jimmygchen
jimmygchen reviewed Sep 23, 2025
View reviewed changes
Comment thread beacon_node/http_api/tests/tests.rs
jimmygchen
jimmygchen reviewed Sep 23, 2025
View reviewed changes
Comment thread beacon_node/http_api/src/lib.rs Outdated
jimmygchen
jimmygchen reviewed Sep 23, 2025
View reviewed changes
Comment thread beacon_node/http_api/src/block_id.rs Outdated
jimmygchen
jimmygchen reviewed Sep 23, 2025
View reviewed changes
Comment thread beacon_node/http_api/src/block_id.rs Outdated
jimmygchen
jimmygchen reviewed Sep 23, 2025
View reviewed changes
Comment thread beacon_node/http_api/src/block_id.rs Outdated
jimmygchen
jimmygchen requested changes Sep 23, 2025
View reviewed changes

@jimmygchen jimmygchen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey CK, thanks for the PR. I've added my thoughts, let me know what you think and if you have any questions!

@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Sep 23, 2025
@jimmygchen

jimmygchen commented Sep 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

btw very thorough with the spec compliance, i think the impl great in terms of correctness, and thanks for the test outputs. Nice work 👍

@jimmygchen jimmygchen added v8.0.0 Q4 2025 Fusaka Mainnet Release and removed v8.0.0-rc.0 Q3 2025 release for Fusaka on Holesky labels Sep 25, 2025
@jimmygchen

jimmygchen commented Sep 25, 2025

Copy link
Copy Markdown
Member

Bumping this to v8 mainnet release

@chong-he chong-he added the ready-for-review The code is ready for review label Oct 6, 2025
jimmygchen
jimmygchen reviewed Oct 8, 2025
View reviewed changes
Comment thread beacon_node/beacon_chain/src/kzg_utils.rs Outdated
jimmygchen
jimmygchen reviewed Oct 8, 2025
View reviewed changes
Comment thread beacon_node/http_api/src/block_id.rs
@jimmygchen jimmygchen added waiting-on-author The reviewer has suggested changes and awaits thier implementation. and removed ready-for-review The code is ready for review labels Oct 8, 2025
@chong-he
Revert "change output"
329d72f 
This reverts commit 4de15ca.
jimmygchen
jimmygchen approved these changes Oct 8, 2025
View reviewed changes

@jimmygchen jimmygchen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great now, thanks @chong-he !

@jimmygchen jimmygchen added ready-for-merge This PR is ready to merge. and removed waiting-on-author The reviewer has suggested changes and awaits thier implementation. labels Oct 8, 2025
@mergify mergify Bot added the queued label Oct 8, 2025
@jimmygchen jimmygchen mentioned this pull request Oct 8, 2025
Closed
mergify Bot added a commit that referenced this pull request Oct 8, 2025
@mergify
Merge of #8103
408ac56
@mergify mergify Bot mentioned this pull request Oct 8, 2025
Closed
6 tasks
@mergify

mergify Bot commented Oct 8, 2025

Copy link
Copy Markdown

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You can check the last failing draft PR here: #8173.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@mergify mergify Bot removed the queued label Oct 8, 2025
@michaelsproul

michaelsproul commented Oct 9, 2025

Copy link
Copy Markdown
Member

@mergify requeue

@mergify

mergify Bot commented Oct 9, 2025

Copy link
Copy Markdown

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify Bot added the queued label Oct 9, 2025
mergify Bot added a commit that referenced this pull request Oct 9, 2025
@mergify
Merge of #8103
df7d071
@mergify mergify Bot mentioned this pull request Oct 9, 2025
Closed
6 tasks
@mergify mergify Bot merged commit 3110ca3 into sigp:unstable Oct 9, 2025
37 checks passed
@mergify mergify Bot removed the queued label Oct 9, 2025
@chong-he chong-he deleted the implement-getBlobs branch October 9, 2025 06:10
jchavarri pushed a commit to jchavarri/lighthouse that referenced this pull request Oct 21, 2025
@chong-he @jchavarri
Implement /eth/v1/beacon/blobs endpoint (sigp#8103)
35fdb60 
* sigp#8085


  


Co-Authored-By: Tan Chee Keong <[email protected]>

Co-Authored-By: chonghe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimmygchen jimmygchen jimmygchen approved these changes

Assignees

No one assigned

Labels

HTTP-API ready-for-merge This PR is ready to merge. v8.0.0 Q4 2025 Fusaka Mainnet Release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chong-he @jimmygchen @michaelsproul