Create network_utils crate#7761
Merged
Merged
Conversation
Member
|
Love this idea! Just needs a |
macladson
added
waiting-on-author
mergify
Bot
added
ready-for-review
|
Some required checks have failed. Could you please take a look @dknopik? 🙏 |
mergify
Bot
added
waiting-on-author
AgeManning
approved these changes
Sep 10, 2025
AgeManning
left a comment
AgeManning
left a comment
Member
There was a problem hiding this comment.
This refactor seems good to me
mergify
Bot
added
ready-for-review
jimmygchen
added
ready-for-merge
6 tasks
PoulavBhowmick03
pushed a commit
to PoulavBhowmick03/lighthouse
that referenced
this pull request
Sep 12, 2025
Anchor currently depends on `lighthouse_network` for a few types and utilities that live within. As we use our own libp2p behaviours, we actually do not use the core logic in that crate. This makes us transitively depend on a bunch of unneeded crates (even a whole separate libp2p if the versions mismatch!) Move things we require into it's own lightweight crate. Co-Authored-By: Daniel Knopik <[email protected]>
kevaundray
pushed a commit
to kevaundray/lighthouse
that referenced
this pull request
Sep 13, 2025
Anchor currently depends on `lighthouse_network` for a few types and utilities that live within. As we use our own libp2p behaviours, we actually do not use the core logic in that crate. This makes us transitively depend on a bunch of unneeded crates (even a whole separate libp2p if the versions mismatch!) Move things we require into it's own lightweight crate. Co-Authored-By: Daniel Knopik <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Anchor currently depends on
lighthouse_networkfor a few types and utilities that live within. As we use our own libp2p behaviours, we actually do not use the core logic in that crate. This makes us transitively depend on a bunch of unneeded crates (even a whole separate libp2p if the versions mismatch!)Proposed Changes
Move things we require into it's own lightweight crate.
Additional Info
CC @diegomrsantos, wdyt?