Merge pull request haskell-github#187 from phadej/search-tests-no-network

phadej · phadej · commit 36de1470385b · 2016-02-01T10:35:57.000+02:00
Don't require network for search tests
diff --git a/spec/GitHub/SearchSpec.hs b/spec/GitHub/SearchSpec.hs
@@ -5,20 +5,29 @@ module GitHub.SearchSpec where
 import Prelude        ()
 import Prelude.Compat
 
-import Data.Aeson.Compat (eitherDecodeStrict)
-import Data.FileEmbed    (embedFile)
-import Test.Hspec        (Spec, describe, it, shouldBe)
+import Data.Aeson.Compat  (eitherDecodeStrict)
+import Data.FileEmbed     (embedFile)
+import Data.Proxy         (Proxy (..))
+import Data.String        (fromString)
+import System.Environment (lookupEnv)
+import Test.Hspec         (Spec, describe, it, pendingWith, shouldBe)
 
 import qualified Data.Vector as V
 
-import GitHub.Data.Id     (Id (..))
-import GitHub.Data.Issues (Issue (..))
-import GitHub.Endpoints.Search      (SearchResult (..), searchIssues)
+import GitHub.Data             (Auth (..), Issue (..), mkId)
+import GitHub.Endpoints.Search (SearchResult (..), searchIssues')
 
 fromRightS :: Show a => Either a b -> b
 fromRightS (Right b) = b
 fromRightS (Left a) = error $ "Expected a Right and got a Left" ++ show a
 
+withAuth :: (Auth -> IO ()) -> IO ()
+withAuth action = do
+  mtoken <- lookupEnv "GITHUB_TOKEN"
+  case mtoken of
+    Nothing    -> pendingWith "no GITHUB_TOKEN"
+    Just token -> action (OAuth $ fromString token)
+
 spec :: Spec
 spec = do
   describe "searchIssues" $ do
@@ -30,19 +39,19 @@ spec = do
       V.length issues `shouldBe` 2
 
       let issue1 = issues V.! 0
-      issueId issue1 `shouldBe` Id 123898390
+      issueId issue1 `shouldBe` mkId (Proxy :: Proxy Issue) 123898390
       issueNumber issue1 `shouldBe` 130
       issueTitle issue1 `shouldBe` "Make test runner more robust"
       issueState issue1 `shouldBe` "closed"
 
       let issue2 = issues V.! 1
-      issueId issue2 `shouldBe` Id 119694665
+      issueId issue2 `shouldBe` mkId (Proxy :: Proxy Issue) 119694665
       issueNumber issue2 `shouldBe` 127
       issueTitle issue2 `shouldBe` "Decouple request creation from execution"
       issueState issue2 `shouldBe` "open"
 
-    it "performs an issue search via the API" $ do
+    it "performs an issue search via the API" $ withAuth $ \auth -> do
       let query = "Decouple in:title repo:phadej/github created:<=2015-12-01"
-      issues <- searchResultResults . fromRightS <$> searchIssues query
+      issues <- searchResultResults . fromRightS <$> searchIssues' (Just auth) query
       length issues `shouldBe` 1
-      issueId (V.head issues) `shouldBe` Id 119694665
+      issueId (V.head issues) `shouldBe` mkId (Proxy :: Proxy Issue) 119694665
