Skip to content

fix(zone.js): should not try to patch fetch if it is not writable #36311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JiaLiPassion wants to merge 1 commit into from
Closed

fix(zone.js): should not try to patch fetch if it is not writable #36311

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions packages/zone.js/lib/common/promise.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
import {patchMethod} from './utils';

/**
* @license
* Copyright Google Inc. All Rights Reserved.
Expand Down Expand Up @@ -500,8 +502,8 @@ Zone.__load_patch('ZoneAwarePromise', (global: any, Zone: ZoneType, api: _ZonePr
api.patchThen = patchThen;

function zoneify(fn: Function) {
return function(this: unknown) {
let resultPromise = fn.apply(this, arguments);
return function(self: any, args: any[]) {
let resultPromise = fn.apply(self, args);
if (resultPromise instanceof ZoneAwarePromise) {
return resultPromise;
}
Expand All @@ -515,11 +517,7 @@ Zone.__load_patch('ZoneAwarePromise', (global: any, Zone: ZoneType, api: _ZonePr

if (NativePromise) {
patchThen(NativePromise);
const fetch = global['fetch'];
if (typeof fetch == 'function') {
global[api.symbol('fetch')] = fetch;
global['fetch'] = zoneify(fetch);
}
patchMethod(global, 'fetch', delegate => zoneify(delegate));
}

// This is not part of public API, but it is useful for tests, so we expose it.
Expand Down