fix: silent does not always work (fixes #851) by uttpal · Pull Request #861 · shelljs/shelljs

uttpal · 2018-06-23T14:59:50Z

No description provided.

codecov-io · 2018-06-23T15:17:09Z

Codecov Report

Merging #861 into master will not change coverage.
The diff coverage is 100%.

@@          Coverage Diff           @@
##           master    #861   +/-   ##
======================================
  Coverage    95.8%   95.8%           
======================================
  Files          34      34           
  Lines        1262    1262           
======================================
  Hits         1209    1209           
  Misses         53      53

Impacted Files	Coverage Δ
src/exec.js	`97.1% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9d443...5190896. Read the comment docs.

nfischer

Thanks for this quick fix! Left a couple comments, otherwise this is a great help.

nfischer · 2018-06-24T23:45:19Z

src/exec.js


  if (code !== 0) {
-    common.error(stderr, code, { continue: true });
+    common.error(stderr, code, { continue: true, silent: opts.silent });


Actually, I believe correct behavior (comparing against v0.7.8) is to never print this. So, this should be silent: true.

just to clarify, here silent: true will always be there?

In my previous comment, I intended for you to change this line to:

common.error(stderr, code, { continue: true, silent: true });

nfischer · 2018-06-24T23:50:57Z

test/exec.js

  t.is(result.stderr, '1234\n');
 });

+test('check if stdout + stderr should not be printed to console if silent', t => {


This test is great. Can you also add a second test to handle the case for silent: false?

Optional suggestion: you can replace the command with shell.exec('shx ls resources/file1.txt filethatdoesnotexist'). shx ls is cross-platform, guaranteed to produce both stdout & stderr, and guaranteed to have a non-zero exit code.

Above you suggested that silent will always be true, then there will be no silent: falsecase?

Above you suggested that silent will always be true

For this PR, correct behavior is to always pass { silent: true } to common.error(), regardless of config.silent or exec's { silent: true } option.

then there will be no silent: false case?

I think two cases are interesting:

when the user passes silent: true, there should be no stdio

when the user passes silent: false (or, equivalently, the default), the command's stdio should go to stdio, but exec should not also print exec: <something here> to stderr

Does this make sense?

@uttpal any update?

I will fix and add test asap

nfischer · 2018-06-25T00:05:50Z

test/exec.js

 shell.config.silent = true;

+test.beforeEach(() => {
+  mocks.init();


This line is OK as written. This actually exposes a bug (#862), which I will handle.

FYI fix is uploaded (#863). It's OK if this PR lands first.

3rd-Eden · 2018-09-20T13:14:34Z

Any update on this? The current work around is to globally silent the module using sh.config.silent = true so the build-in log function doesn't output anything. It would be nice if this PR could be merged and released.

nfischer · 2018-09-20T20:00:54Z

I believe I still need a change from @uttpal (if that's not the case, please let me know I should re-review this).

nfischer · 2018-10-10T02:46:52Z

FYI I cherry-picked this to #892

Unconditionally apply `silent: true` when calling `common.error()` from `exec()`. This is because errors are already printed to stderr, or are intentionally silenced by `shell.config.silent`. Based on #861 Fixes #851

nfischer · 2018-10-27T20:52:14Z

Close in favor of #892

fix: silent does not always work shelljs#851

5190896

uttpal changed the title ~~fix: silent does not always work #851~~ fix: silent does not always work (fixes #851) Jun 23, 2018

nfischer mentioned this pull request Jun 25, 2018

test infra: mocks and skipOnWin conflict #862

Closed

nfischer requested changes Jun 25, 2018

View reviewed changes

nfischer added this to the v0.8.x milestone Jul 12, 2018

This was referenced Oct 9, 2018

Redundant printing of stderr when using exec #891

Closed

Fix silent exec #892

Merged

nfischer closed this Oct 27, 2018

Conversation

uttpal commented Jun 23, 2018

Uh oh!

codecov-io commented Jun 23, 2018

Codecov Report

Uh oh!

nfischer left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

uttpal Jun 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

3rd-Eden commented Sep 20, 2018

Uh oh!

nfischer commented Sep 20, 2018

Uh oh!

nfischer commented Oct 10, 2018

Uh oh!

nfischer commented Oct 27, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

uttpal Jun 25, 2018 •

edited

Loading