Gloas new p2p topics#11
Closed
shane-moore wants to merge 3 commits into
Closed
Conversation
8dbcd01 to
fbdb997
Compare
13fdf73 to
eb80c44
Compare
Owner
Author
|
Closing — fully upstreamed. The three GLOAS gossip topics this PR added ( The PR's stated TODOs (envelope/payload-attestation verification + reprocess) are also done upstream via sigp#9145 ("Gloas PayloadAttestation gossip verification", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New P2P Topics Added
execution_payloadSignedExecutionPayloadEnvelopeper the specpayload_attestation_messageTODO
execution_payloadgossiping flow will need to hook into the upcomingenvelope_verification.rsfor validation logic before forwarding on a received envelope. Similarly, thepayload_attestation_messagewill need to hook into a newpayload_attestation_verification.rsmodule once that's implemented.