script: Add error messages for the ECDH cryptographic functions #41468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PaulTreitel <[email protected]>
servo-highfive
added
the
S-awaiting-review
kkoyung
approved these changes
Dec 22, 2025
Member
kkoyung
left a comment
kkoyung
left a comment
There was a problem hiding this comment.
Looks good once the merge conflict is resolved.
servo-highfive
added
S-needs-rebase
…ks (servo#41428) Add several helper functions to JsonWebKey to handle common base64url decoding tasks across multiple algorithms. Those helper functions include: - `JsonWebKey::decode_optional_string_field`: decode optional field - `JsonWebKey::decode_required_string_field`: decode required field - `JsonWebKey::decode_primes_from_oth_field`: decode oth field to primes These help simplify our code for importing keys in JsonWebKey format. Testing: Refactoring. Existing tests suffice. Signed-off-by: Kingsley Yung <[email protected]>
Expose `replace_host_table` via test_util so it can be reused by other
crates, notably libservo tests.
This allows tests to map arbitrary host names to localhost, so loading
of
arbitrary sites can be done via the lightweight http server (without
reaching
the external network).
Arbitrary sites are needed for upcoming `SiteDataManager` site grouping
by
domain.
Testing: A new integration test has been added
Signed-off-by: Jan Varga <[email protected]>
…rvo#41475) When the original display of an absolutely positioned element changes, the static position can be affected. However, the static position is only used when both insets in the same axis are `auto`. Therefore, this patch avoids dirtying the box tree when both axes have a non-auto inset. Testing: Not needed, this should have no observable behavior change Signed-off-by: Oriol Brufau <[email protected]>
Fixes the corner case where server notifies TIMEOUT through JS. We now enforces WebDriver page load timeout. Also reduces runtime by eliminating unnecessary wait. Testing: 15 consecutive successes. https://github.com/servo/servo/actions/runs/20424254640 https://github.com/servo/servo/actions/runs/20424278175 https://github.com/servo/servo/actions/runs/20424275366 https://github.com/servo/servo/actions/runs/20424009716 https://github.com/servo/servo/actions/runs/20424461693 https://github.com/servo/servo/actions/runs/20424475579 https://github.com/servo/servo/actions/runs/20424957847 https://github.com/servo/servo/actions/runs/20424955422 https://github.com/servo/servo/actions/runs/20424953070 ... How network issue/failure is addressed: https://github.com/servo/servo/actions/runs/20430835294/job/58701225338 Fixes: servo#41467 --------- Signed-off-by: Euclid Ye <[email protected]>
…k` around `FontGroup` (servo#41449) This change reworks the logic for finding font fallbacks to make it simpler. I was involved with writing the code for `FontGroupFamily` and `FontGroupFamilyMember` and I still struggle a bit with understanding it, so I've chosen to do this. In addition, the change is in preparation for more flexible font fallback (servo#41426). The main changes here are: 1. Move the logic for creating a new descriptor with variations into the Font constructor. 2. Add some more general methods to `FontGroupFamily` such as a template iterator. 3. Use `OnceLock` to avoid a convoluted code structure because of mutability and also having boolean "loaded" members. This is what `OnceLock` and `OnceCell` are for! 4. Rename `FontGroupFamilyMember` to `FontGroupFamilyTemplate` to stress that it is one template of a particular `FontGroupFamily`. Testing: This should not change behavior so is covered by existing WPT tests. --------- Signed-off-by: Martin Robinson <[email protected]>
Signed-off-by: PaulTreitel <[email protected]>
PaulTreitel
requested review from
Loirooriol,
mrobinson and
nicoburns
as code owners
servo-highfive
added
S-awaiting-review
Signed-off-by: PaulTreitel <[email protected]>
servo-highfive
added
S-needs-rebase
Signed-off-by: PaulTreitel <[email protected]>
Contributor
Author
|
I apologize if I mucked up this PR. My git skills are underwhelming at best and I wasn't 100% sure what to do. Let me know if there's something I need to fix. |
Contributor
|
You need to sign off your commit (use |
mrobinson
reviewed
Dec 23, 2025
Member
mrobinson
left a comment
mrobinson
left a comment
There was a problem hiding this comment.
Just waiting on a signed version of this commit and then one comment:
| let public_key_err = | ||
| Error::Operation(Some("Failed to export public key".to_string())); | ||
| let private_key_err = | ||
| Error::Operation(Some("Failed to export private key".to_string())); |
Member
There was a problem hiding this comment.
It might be worth making these functions so that you don't always allocate here.
Suggested change
| Error::Operation(Some("Failed to export private key".to_string())); | |
| let public_key_err = || | |
| Error::Operation(Some("Failed to export public key".to_string())); | |
| let private_key_err = || | |
| Error::Operation(Some("Failed to export private key".to_string())); |
Member
@PaulTreitel I suggest you roll back to your commit, and then rebase on the main branch from there. This should make your branch cleaner. # Checkout and pull main branch to get latest commits
git checkout main
git pull
# Checkout your branch
git checkout issue-40756/ecdh
# Make a backup branch (just in case you need to rescue your work).
git branch issue-40756/ecdh/backup
# Roll back to your first commit
git reset --hard 8be314002c2
# Rebase on the main branch
git rebase main
# Resolve the conflict in your editor
# Continue the rebase
git add components/script/dom/subtlecrypto/ecdh_operation.rs
git rebase --continueYou can then do other changes and make new commit. You will need a force push ( Feel free to ask if you encounter any problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding error messages across
script/dom/subtlecrypto/ecdh_operation.rs.Testing: No tests as this is just adding error messages
Fixes: (part of) #40756