Remove logback from test dependencies#1238
Merged
ricardozanini merged 1 commit intoserverlessworkflow:mainfrom Mar 16, 2026
Merged
Remove logback from test dependencies#1238ricardozanini merged 1 commit intoserverlessworkflow:mainfrom
ricardozanini merged 1 commit intoserverlessworkflow:mainfrom
Conversation
fjtirado
force-pushed
the
Remove_logback_from_test_library
branch
from
9a44ae2 to
fef3735
Compare
ricardozanini
approved these changes
Mar 16, 2026
The test library should not provide any logging library Signed-off-by: fjtirado <[email protected]>
fjtirado
force-pushed
the
Remove_logback_from_test_library
branch
from
fef3735 to
f68bf81
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes logback-classic from the persistence tests module dependencies so the test library does not ship a concrete logging implementation.
Changes:
- Dropped
ch.qos.logback:logback-classicfromimpl/persistence/tests/pom.xml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test library should not provide any logging library