Skip to content

Add the ability to impersonate a subuser#272

Closed
2b7q8 wants to merge 1 commit into
sendgrid:masterfrom
2b7q8:impersonate-subuser
Closed

Add the ability to impersonate a subuser#272
2b7q8 wants to merge 1 commit into
sendgrid:masterfrom
2b7q8:impersonate-subuser

Conversation

@2b7q8

@2b7q8 2b7q8 commented Nov 1, 2017

Copy link
Copy Markdown

Fixes #270

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • Add the ability to impersonate a subuser

If you have questions, please send an email to Sendgrid, or file a Github Issue in this repository.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@SendGridDX

SendGridDX commented Nov 1, 2017

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio labels Feb 12, 2018

@clee clee left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clee clee mentioned this pull request Feb 12, 2018
6 tasks
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious

Copy link
Copy Markdown
Contributor

Closed in favor of #271.

@mote-S,

Even though we did not merge this, we are super grateful for your efforts. Please email us at [email protected] referencing this PR and we will send you some swag, if we have not already.

With Best Regards,

Elmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to impersonate a subuser

4 participants