Skip to content

Add ability to impersonate subuser#271

Merged
thinkingserious merged 2 commits into
sendgrid:masterfrom
danilospa:add-impersonate-subuser
Oct 22, 2018
Merged

Add ability to impersonate subuser#271
thinkingserious merged 2 commits into
sendgrid:masterfrom
danilospa:add-impersonate-subuser

Conversation

@danilospa

@danilospa danilospa commented Nov 1, 2017

Copy link
Copy Markdown
Contributor

Resolves #270

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Short description of what this PR does:

  • It enables a impersonate_subuser parameter on client initialize function. When it's filled, the header On-Behalf-Of is added.

@thinkingserious thinkingserious added the status: code review request requesting a community code review or review from Twilio label Nov 1, 2017
@SendGridDX

SendGridDX commented Nov 1, 2017 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@danilospa

danilospa commented Nov 1, 2017

Copy link
Copy Markdown
Contributor Author

The following tests are breaking because corresponding files do not exist:
test_docker_compose_exists, test_docker_exists, test_codeclimate_exists.
May I remove these tests on this same PR?

@jagthedrummer

jagthedrummer commented Dec 19, 2017

Copy link
Copy Markdown

I'd love to see this get merged.

@thinkingserious

thinkingserious commented Dec 19, 2017

Copy link
Copy Markdown
Contributor

Thanks for the vote @jagthedrummer!

This PR is on our backlog to merge and your vote helps give it priority.

@clee

clee commented Feb 12, 2018

Copy link
Copy Markdown

LGTM - this PR is almost identical to #272, but I think the tests in this one are slightly better. I'd vote we merge this one.

@clee clee added triaged and removed status: code review request requesting a community code review or review from Twilio triaged labels Feb 12, 2018
@thinkingserious thinkingserious added difficulty: medium fix is medium in difficulty type: twilio enhancement feature request on Twilio's roadmap status: ready for deploy code ready to be released in next deploy and removed status: code review complete labels Feb 27, 2018
@thinkingserious thinkingserious mentioned this pull request Mar 6, 2018
Closed
6 tasks
@thinkingserious thinkingserious merged commit 6a9a943 into sendgrid:master Oct 22, 2018
@thinkingserious

thinkingserious commented Oct 22, 2018

Copy link
Copy Markdown
Contributor

Hello @danilospa,

Thanks again for the PR!

We want to show our appreciation by sending you some swag. Could you please fill out this form so we can send it to you? Thanks!

Team SendGrid DX

@Shadowssong

Shadowssong commented Dec 13, 2018

Copy link
Copy Markdown

Hi @thinkingserious do you know when the next release plans to happen? I would like to use this feature but its only on master and has not been released yet (as far as I can tell).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

difficulty: medium fix is medium in difficulty status: ready for deploy code ready to be released in next deploy type: twilio enhancement feature request on Twilio's roadmap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add the ability to impersonate a subuser

6 participants

@danilospa @SendGridDX @jagthedrummer @thinkingserious @clee @Shadowssong