Skip to content

Add endLine in function coverage data#816

Closed
bastien-phi wants to merge 1 commit into
sebastianbergmann:masterfrom
bastien-phi:add_endline_in_function_coverage_data
Closed

Add endLine in function coverage data#816
bastien-phi wants to merge 1 commit into
sebastianbergmann:masterfrom
bastien-phi:add_endline_in_function_coverage_data

Conversation

@bastien-phi

Copy link
Copy Markdown
Contributor

Coverage data for function does not have 'endLine' but data is available. Adding it will be convenient to implement cevrage for non-class based line in Cobertura format (see #812 (comment))

@codecov

codecov Bot commented Sep 30, 2020

Copy link
Copy Markdown

Codecov Report

Merging #816 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #816   +/-   ##
=========================================
  Coverage     83.09%   83.10%           
  Complexity     1094     1094           
=========================================
  Files            62       62           
  Lines          3562     3563    +1     
=========================================
+ Hits           2960     2961    +1     
  Misses          602      602           
Impacted Files Coverage Δ Complexity Δ
src/Node/File.php 79.79% <100.00%> (+0.06%) 109.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6037d7...a09274b. Read the comment docs.

@sebastianbergmann

Copy link
Copy Markdown
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it as by itself this change does not make any sense to me. You can make this change as part of a larger pull request that implements support for the Cobertura XML report for code in the global scope.

@bastien-phi

Copy link
Copy Markdown
Contributor Author

No problem.

I thought it made sense to split the two features across different pull requests.

@bastien-phi bastien-phi deleted the add_endline_in_function_coverage_data branch September 30, 2020 11:59
@sebastianbergmann

Copy link
Copy Markdown
Owner

I agree, although in this case it somehow feels wrong. Sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants