Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3653 +/- ##
==========================================
+ Coverage 78.23% 78.36% +0.13%
==========================================
Files 117 117
Lines 12661 12782 +121
==========================================
+ Hits 9905 10017 +112
- Misses 2756 2765 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This reverts commit b158545.
|
TODO: add |
| return { | ||
| Preset.ScanpyV1: RankGenesGroupsPreset(method="t-test", mask_var=None), | ||
| Preset.ScanpyV2Preview: RankGenesGroupsPreset( | ||
| method="wilcoxon", mask_var=None |
There was a problem hiding this comment.
mask_var="highly_variable" here?
There was a problem hiding this comment.
Maybe collect these sorts of questions and make a zulip/slack poll?
There was a problem hiding this comment.
Definitely. The issue is that they’re hard to collect, I keep stumbling upon more.
|
@ilan-gold I asked your review because of scope:
|
ilan-gold
left a comment
ilan-gold
left a comment
There was a problem hiding this comment.
This is a pretty harmless PR so nothing comes to mind as absolutely pressing. The architecture overall makes sense.
I would beef up the docs a bit to make it clear how to use this.
Why use ScanpyV2Preview instead of just ScanpyV2?
| return { | ||
| Preset.ScanpyV1: RankGenesGroupsPreset(method="t-test", mask_var=None), | ||
| Preset.ScanpyV2Preview: RankGenesGroupsPreset( | ||
| method="wilcoxon", mask_var=None |
There was a problem hiding this comment.
Maybe collect these sorts of questions and make a zulip/slack poll?
Because when we release a new feature release before 2.0, I don’t want people to start relying on it keeping its behavior. I thought “preview” makes it clear that it’s not stable, but I’m open to suggestions. |
ilan-gold
left a comment
ilan-gold
left a comment
There was a problem hiding this comment.
Modulo the repr (whcih I do think is worth discussion at the minmum if not a tweak), looks great!!!
2 participants
Self-documenting presets work!
E.g.:
scanpy/src/scanpy/_settings.py
Lines 90 to 96 in 3bae7ae