introduce PMD/category/java/errorprone.xml/CloneMethodReturnTypeMustMatchClassName rule

kullfar · kullfar · commit 9137ca6a369c · 2019-04-04T18:41:52.000+03:00
diff --git a/pmd.xml b/pmd.xml
@@ -73,4 +73,5 @@
     <rule ref="category/java/errorprone.xml/ClassCastExceptionWithToArray" />
     <rule ref="category/java/errorprone.xml/CloneMethodMustBePublic" />
     <rule ref="category/java/errorprone.xml/CloneMethodMustImplementCloneable" />
+    <rule ref="category/java/errorprone.xml/CloneMethodReturnTypeMustMatchClassName" />
 </ruleset>
diff --git a/scribejava-httpclient-okhttp/src/test/java/com/github/scribejava/httpclient/okhttp/MockCall.java b/scribejava-httpclient-okhttp/src/test/java/com/github/scribejava/httpclient/okhttp/MockCall.java
@@ -49,7 +49,7 @@ public boolean isExecuted() {
     }
 
     @Override
-    public Call clone() {
+    public MockCall clone() {
         throw new UnsupportedOperationException("Not supported yet.");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -49,7 +49,7 @@ public boolean isExecuted() {`
`49`	`49`	`}`
`50`	`50`
`51`	`51`	`@Override`
`52`		`- public Call clone() {`
	`52`	`+ public MockCall clone() {`
`53`	`53`	`throw new UnsupportedOperationException("Not supported yet.");`
`54`	`54`	`}`
`55`	`55`