add checkstyle rules, fix ArrayTypeStyle

s-gromov · s-gromov · commit 8049d61fd571 · 2016-01-25T13:59:42.000+03:00
diff --git a/checkstyle.xml b/checkstyle.xml
@@ -54,5 +54,12 @@
         <module name="SimplifyBooleanReturn"/>
         <module name="StringLiteralEquality"/>
         <module name="UnnecessaryParentheses"/>
+        <module name="AvoidStarImport"/>
+        <module name="IllegalImport">
+            <property name="illegalPkgs" value="sun, junit.framework"/>
+        </module>
+        <module name="RedundantImport"/>
+        <module name="UnusedImports"/>
+        <module name="ArrayTypeStyle"/>
     </module>
 </module>
diff --git a/scribejava-core/src/main/java/com/github/scribejava/core/model/ParameterList.java b/scribejava-core/src/main/java/com/github/scribejava/core/model/ParameterList.java
@@ -73,7 +73,7 @@ public void addAll(ParameterList other) {
     public void addQuerystring(String queryString) {
         if (queryString != null && queryString.length() > 0) {
             for (String param : queryString.split(PARAM_SEPARATOR)) {
-                final String pair[] = param.split(PAIR_SEPARATOR);
+                final String[] pair = param.split(PAIR_SEPARATOR);
                 final String key = OAuthEncoder.decode(pair[0]);
                 final String value = pair.length > 1 ? OAuthEncoder.decode(pair[1]) : EMPTY_STRING;
                 params.add(new Parameter(key, value));
diff --git a/scribejava-core/src/test/java/com/github/scribejava/core/utils/OAuthEncoderTest.java b/scribejava-core/src/test/java/com/github/scribejava/core/utils/OAuthEncoderTest.java
@@ -53,8 +53,8 @@ public void shouldThrowExceptionIfStringToDecodeIsNull() {
     @Test
     public void shouldPercentEncodeCorrectlyTwitterCodingExamples() {
         // These tests are part of the Twitter dev examples here -> https://dev.twitter.com/docs/auth/percent-encoding-parameters
-        final String sources[] = {"Ladies + Gentlemen", "An encoded string!", "Dogs, Cats & Mice"};
-        final String encoded[] = {"Ladies%20%2B%20Gentlemen", "An%20encoded%20string%21", "Dogs%2C%20Cats%20%26%20Mice"};
+        final String[] sources = {"Ladies + Gentlemen", "An encoded string!", "Dogs, Cats & Mice"};
+        final String[] encoded = {"Ladies%20%2B%20Gentlemen", "An%20encoded%20string%21", "Dogs%2C%20Cats%20%26%20Mice"};
 
         for (int i = 0; i < sources.length; i++) {
             Assert.assertEquals(encoded[i], OAuthEncoder.encode(sources[i]));
