Fixed Model.import_data for empty dict #584
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #584 +/- ##
=======================================
Coverage 91.06% 91.06%
=======================================
Files 24 24
Lines 2541 2541
=======================================
Hits 2314 2314
Misses 227 227
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you call
Model.import_dict()with a dictionary that is created by some other part of your program, it might be empty, but theimport_dictmethod should still work the same way as it would if the dictionary had any values in it, i.e. convert only the incoming data (of which there isn't any). Otherwise it leads to data being converted twice, which is unacceptable as it can cause corruption of the stored data.