fix(API): sbpp_checker library name#1034
Merged
rumblefrog merged 5 commits intosbpp:php81from Apr 12, 2025
Merged
Conversation
Contributor
Author
Member
|
Is this ready for review, or still draft? |
Contributor
Author
|
Draft. I need to edit it later today. |
Contributor
Author
|
@rumblefrog Ready to be merged with a squash commit. |
Contributor
|
Hello @rumblefrog any input? |
Member
|
I will remind myself to take a look when I can, but if it looks good to you, you can stamp it. |
rumblefrog
reviewed
Feb 6, 2025
maxime1907
reviewed
Feb 14, 2025
rumblefrog
approved these changes
Apr 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix library name conflict between
sbpp_checkerandsbpp_main(both were usingsourcebans++)sbpp_mainkeepssourcebans++sbpp_checkernow usessourcebanspp_checkerThis allows proper verification of specific libraries via
LibraryExistsand avoids any confusion between the two plugins.Description
The main issue is a library name conflict where both sbpp_checker and sbpp_main were using the same name "sourcebans++" when registering their library via
RegPluginLibrary. This was causing problems when checking for library existence withLibraryExists.Motivation and Context
LibraryExistswithsourcebans++for using sbpp checker natives, wich was always incorrect to due the sameRegPluginLibraryas sbpp_main.How Has This Been Tested?
Tested with a test plugin implementing all new forwards:
Screenshots (if appropriate):
Types of changes
Checklist: