Pytest 5.0 contextmanager str: call value on ExceptionInfo objects#53680
Merged
Conversation
garethgreenaway
approved these changes
Jul 2, 2019
dwoz
approved these changes
Jul 2, 2019
s0undt3ch
approved these changes
Jul 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The tests:
are failing on mac osx because it is installing pytest 5.0.0.
This is due to the removal of
__str__here pytest-dev/pytest#5413Updated the tests to call
.valuealso see comment here: pytest-dev/pytest#5528 (comment)What issues does this PR fix or reference?
Previous Behavior
tests failing:
New Behavior
test pass on pytest <=5.0.0
Tests written?
No -fixes test
Commits signed with GPG?
Yes