Merged
Conversation
…t-dev#3896) * [docs] updated development guide to include compiling the protos Signed-off-by: franciscojavierarceo <[email protected]> * adding note on spinning up the docker image Signed-off-by: franciscojavierarceo <[email protected]> --------- Signed-off-by: franciscojavierarceo <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
Signed-off-by: Hai Nguyen <[email protected]>
chore: set upper bound for moto package Signed-off-by: Hai Nguyen <[email protected]>
Modify the README to point to correct project list Signed-off-by: Twinkll Sisodia <[email protected]>
|
Can you please explain how you synced from the upstream? There's a lot of changes and would like to be extra careful. |
Author
|
Yeah, there were a lot of changes and that's why I created a PR to review and be careful. I created a branch |
alex-vinnik-sp
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing upstream repo. Saw that the fastapi was already updated in upstream: feast-dev#3938.