Skip to content

ThreadPool 2.0#100

Open
dns2utf8 wants to merge 7 commits intomasterfrom
2.0
Open

ThreadPool 2.0#100
dns2utf8 wants to merge 7 commits intomasterfrom
2.0

Conversation

@dns2utf8
Copy link
Member

This is a first draft for 2.0 where I tried to in-cooperate my thoughts on several of the open issues.

I would like to get some feed back over the next week. Eg. "no opinion" or "overloaded" or "looks good" or anything else.

Maybe some of the functionality should reside outside of this crate, like the detection of pinning.

Cheers,
Stefan

ping: @frewsxcv

@rbtcollins
Copy link

We're using this in rustup; no particular view on 2.0; 1.x is pretty nice.

@frewsxcv
Copy link
Collaborator

frewsxcv commented Jun 8, 2019

Hey @dns2utf8, I appreciate you putting in the effort to write this proposal! Although I'm very limited on time nowadays and don't have the bandwidth to review this right now. Maybe someone else in the Rust community could help out with this?

@dns2utf8
Copy link
Member Author

Thank you all for the feedback :)
I will focus my first effort on cleaning up the API in the 2.0 branch.

@frewsxcv that is okay, I will find someone.

Hope you can enjoy the summer weather sometimes 🦀
And if you are at CCCamp we could meet there.

Cheers,
Stefan

@QuRyu
Copy link

QuRyu commented Aug 4, 2019

Disclaimer: this is my first time to actually participate in open source community so some ideas might look naive and totally wrong.

It seems to me that the feature "Access to the pool handle from within the task" is not very much needed (I didn't find the corresponding issue tho). What would be the use case of it?

As for NUMA optimizations, will that involve pin threads to a particular core and box the passed-in function onto the memory adjacent to the particular core? If all threads are busy, how does the scheduler decide which function to send to which core? I am just curious about the implementation and would like to contribute to that part if possible, since coding it sounds very fascinating :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.0 Currently planed for 2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants