Add smol_str 0.2 and 0.3 support (continued #1095) #1298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use map instead of ? smol_str 0.3 support Formatting
docs: refactor for DRY feature_docs.md of tokio-postgres,postgres,postgres-types as mentioned in rust-postgres#1095 (comment) chore: alphabetize with-* imports in Cargo.toml for tokio-postgres,postgres,postgres-types chore: squashed @novacrazy's changes in rust-postgres#1095, rebased to master in accordance with rust-postgres#1095 (comment),
paolobarbolini
requested changes
Dec 14, 2025
Member
There was a problem hiding this comment.
Thanks for taking over #1095.
If you can could you split individual changes, like reordering items in Cargo.toml and moving features to a shared .md file, into separate commits?
| //! | `with-uuid-1` | Enable support for the `uuid` crate. | [uuid](https://crates.io/crates/uuid) 1.0 | no | | ||
| //! | `with-time-0_2` | Enable support for the 0.2 version of the `time` crate. | [time](https://crates.io/crates/time/0.2.0) 0.2 | no | | ||
| //! | `with-time-0_3` | Enable support for the 0.3 version of the `time` crate. | [time](https://crates.io/crates/time/0.3.0) 0.3 | no | | ||
| #![doc = include_str!("../../postgres-types/feature_docs.md")] |
Member
There was a problem hiding this comment.
I don't think this is going to work in the docs.rs build, given that it won't have access to the entire workspace. This could be resolved with a symlink.
| //! | ||
| //! # Features | ||
| //! | ||
| #![doc=include_str!("../../postgres-types/feature_docs.md")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued @novacrazy's #1095
I can commit half an hour to make any changes, but pushing (use the Force maintainers) to this branch would be appreciated.