Support build on wasm32 #1146
Support build on wasm32 #1146
Conversation
|
We already test that the crate compiles against wasm32: https://github.com/sfackler/rust-postgres/blob/master/.github/workflows/ci.yml#L50-L75. If tokio gains direct wasm32 support I'd be happy to expand the supported feature set here, but I don't want to make changes that only work when building against an unspecified tokio fork. |
|
This is not specific to a particular tokio; it’s just that this crate does not define KeepaliveConfig in wasm32. I’ve ignored all references to KeepaliveConfig in wasm32, and I believe these changes are reasonable. |
|
The |
|
I am pretty sure that my changes work with standard tokio. Your CI still passes with this PR. |
Signed-off-by: csh <[email protected]>
Could you change the CI configuration so that the wasm32 job enables the |
|
My apologies, this PR is quite old now, and I’ve forgotten most of the details. Just to clarify, is the goal now to make it work with wasm32? If so, I’d be happy to re-test it. |
3 participants
In this line, the parameter KeepaliveConfig is ignored when compiled to wasm32, while there is no corresponding conditional compilation elsewhere. Therefore, I added a conditional compilation for wasm32 in the places where Keepalive is needed. This modification allows the crate to be used normally in wasm32 after replacing the underlying tokio with a patch.