Skip to content

Conversation

@novacrazy
Copy link
Contributor

@novacrazy novacrazy commented Jan 16, 2024

Add smol_str 0.2 and 0.3 support, effectively a copy of the 0.1 file. Though I noticed the feature flags for 0.1 are missing an underscore, but changing that would break things so I just matched it for the new one.

@novacrazy
Copy link
Contributor Author

Any chance this could be merged sometime? Starting to get cyclic dependency errors due to how many crates I've had to patch ToSql/FromSql support into.

@novacrazy novacrazy force-pushed the feature/smol_str-0.2 branch from 21fdfe8 to 798f81b Compare September 7, 2024 02:32
@novacrazy novacrazy changed the title Add smol_str 0.2 support Add smol_str 0.2 and 0.3 support Sep 7, 2024
@novacrazy
Copy link
Contributor Author

This has been open long enough that there's now a 0.3 version of smol_str. Updated and rebased to latest for easier merging.

@paolobarbolini
Copy link
Member

The smol_str v0.1 implementation also has tests 1. Could you also have tests for the v0.2 and v0.3 versions?
Also could you squash your commits into one and rebase your branch on top of the master branch?

Footnotes

  1. https://github.com/rust-postgres/rust-postgres/blob/e1cd6beef3a1530642a2abaf3584d6bd8ed6cd45/tokio-postgres/tests/test/types/smol_str_01.rs

@paolobarbolini
Copy link
Member

These lists also need to be updated:

//! | `with-bit-vec-0_6` | Enable support for the `bit-vec` crate. | [bit-vec](https://crates.io/crates/bit-vec) 0.6 | no |
//! | `with-chrono-0_4` | Enable support for the `chrono` crate. | [chrono](https://crates.io/crates/chrono) 0.4 | no |
//! | `with-eui48-0_4` | Enable support for the 0.4 version of the `eui48` crate. This is deprecated and will be removed. | [eui48](https://crates.io/crates/eui48) 0.4 | no |
//! | `with-eui48-1` | Enable support for the 1.0 version of the `eui48` crate. | [eui48](https://crates.io/crates/eui48) 1.0 | no |
//! | `with-geo-types-0_6` | Enable support for the 0.6 version of the `geo-types` crate. | [geo-types](https://crates.io/crates/geo-types/0.6.0) 0.6 | no |
//! | `with-geo-types-0_7` | Enable support for the 0.7 version of the `geo-types` crate. | [geo-types](https://crates.io/crates/geo-types/0.7.0) 0.7 | no |
//! | `with-serde_json-1` | Enable support for the `serde_json` crate. | [serde_json](https://crates.io/crates/serde_json) 1.0 | no |
//! | `with-uuid-0_8` | Enable support for the `uuid` crate. | [uuid](https://crates.io/crates/uuid) 0.8 | no |
//! | `with-uuid-1` | Enable support for the `uuid` crate. | [uuid](https://crates.io/crates/uuid) 1.0 | no |
//! | `with-time-0_2` | Enable support for the 0.2 version of the `time` crate. | [time](https://crates.io/crates/time/0.2.0) 0.2 | no |
//! | `with-time-0_3` | Enable support for the 0.3 version of the `time` crate. | [time](https://crates.io/crates/time/0.3.0) 0.3 | no |

//! | `with-bit-vec-0_6` | Enable support for the `bit-vec` crate. | [bit-vec](https://crates.io/crates/bit-vec) 0.6 | no |
//! | `with-chrono-0_4` | Enable support for the `chrono` crate. | [chrono](https://crates.io/crates/chrono) 0.4 | no |
//! | `with-eui48-0_4` | Enable support for the 0.4 version of the `eui48` crate. This is deprecated and will be removed. | [eui48](https://crates.io/crates/eui48) 0.4 | no |
//! | `with-eui48-1` | Enable support for the 1.0 version of the `eui48` crate. | [eui48](https://crates.io/crates/eui48) 1.0 | no |
//! | `with-geo-types-0_6` | Enable support for the 0.6 version of the `geo-types` crate. | [geo-types](https://crates.io/crates/geo-types/0.6.0) 0.6 | no |
//! | `with-geo-types-0_7` | Enable support for the 0.7 version of the `geo-types` crate. | [geo-types](https://crates.io/crates/geo-types/0.7.0) 0.7 | no |
//! | `with-jiff-0_1` | Enable support for the 0.1 version of the `jiff` crate. | [jiff](https://crates.io/crates/jiff/0.1.0) 0.1 | no |
//! | `with-serde_json-1` | Enable support for the `serde_json` crate. | [serde_json](https://crates.io/crates/serde_json) 1.0 | no |
//! | `with-uuid-0_8` | Enable support for the `uuid` crate. | [uuid](https://crates.io/crates/uuid) 0.8 | no |
//! | `with-uuid-1` | Enable support for the `uuid` crate. | [uuid](https://crates.io/crates/uuid) 1.0 | no |
//! | `with-time-0_2` | Enable support for the 0.2 version of the `time` crate. | [time](https://crates.io/crates/time/0.2.0) 0.2 | no |
//! | `with-time-0_3` | Enable support for the 0.3 version of the `time` crate. | [time](https://crates.io/crates/time/0.3.0) 0.3 | no |

JakubKoralewski added a commit to JakubKoralewski/rust-postgres that referenced this pull request Nov 23, 2025
docs: refactor for DRY feature_docs.md of tokio-postgres,postgres,postgres-types
as mentioned in rust-postgres#1095 (comment)

chore: alphabetize with-* imports in Cargo.toml for tokio-postgres,postgres,postgres-types

chore: squashed @novacrazy's changes in rust-postgres#1095, rebased to master in accordance with rust-postgres#1095 (comment),
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants