Skip to content

Implement parallel collect to array for non-Copy elements #817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bluss merged 15 commits into from
May 28, 2020
Merged

Implement parallel collect to array for non-Copy elements #817

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
ad856bd
FEAT: Special case D::from_dimension for Ix1
bluss Apr 29, 2020
511f8b2
FIX: Use Zip::fold_while for final reduction in parallel array view
bluss May 1, 2020
192a166
FIX: Make is_contiguous pub(crate)
bluss May 11, 2020
35e89f8
TEST: Add benchmarks for parallel collect
bluss May 11, 2020
84295c4
FEAT: Factor out traits SplitAt and SplitPreference
bluss May 11, 2020
3ab67eb
FEAT: Add ParalleIterator ParallelSplits
bluss May 11, 2020
ee97dbf
TEST: Add parallel collect test for small arrays
bluss May 11, 2020
fe2ebf6
FEAT: Add internal Zip::last_producer
bluss May 11, 2020
4277296
FEAT: Implement generic parallel collect
bluss May 11, 2020
6d43c13
FIX: In ParallelSplits, count maximum number of splits
bluss May 18, 2020
e3ebf8c
FIX: In Zip, fix unused code warning for `last_of` macro
bluss May 18, 2020
efcd607
FIX: Make Partial::new an unsafe method
bluss May 19, 2020
8ed9ac3
FIX: Wrap long lines in impl_par_methods.rs
bluss May 19, 2020
d02b757
FIX: Use Partial instead of PartialArray
bluss May 23, 2020
e472612
FEAT: Combine common parts of apply_collect and par_apply_collect
bluss May 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
FEAT: Add internal Zip::last_producer 
This method is useful for parallel Zip.
  • Loading branch information
@bluss
bluss committed May 19, 2020
commit fe2ebf6eb96a191231751ebae65e76ab94476e76
13 changes: 13 additions & 0 deletions src/zip/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,11 @@ zipt_impl! {
[A B C D E F][ a b c d e f],
}

macro_rules! last_of {
($q:ty) => { $q };
($p:ty, $($q:ty),+) => { last_of!($($q),+) };
}

macro_rules! map_impl {
($([$notlast:ident $($p:ident)*],)+) => {
$(
Expand Down Expand Up @@ -1012,6 +1017,14 @@ macro_rules! map_impl {
}).is_done()
}

#[cfg(feature = "rayon")]
#[allow(dead_code)] // unused for the first of the Zip arities
/// Return a reference to the last producer
pub(crate) fn last_producer(&self) -> &last_of!($($p),*) {
let (.., ref last) = &self.parts;
last
}

expand_if!(@bool [$notlast]

/// Include the producer `p` in the Zip.
Expand Down