Add Automatic-Module-Name for Jigsaw modules support #1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@rubenlagus could you take a look at the commit? |
rubenlagus
force-pushed
the
dev
branch
2 times, most recently
from
bc4fd52 to
65c33e0
Compare
Owner
|
this MR is pre-version 7, will need some changes to be able to merge. |
rubenlagus
force-pushed
the
dev
branch
2 times, most recently
from
68a6f61 to
5fc7d88
Compare
rubenlagus
force-pushed
the
dev
branch
3 times, most recently
from
52a184e to
9203912
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am encountering a problem while attempting to use the telegrambots library in my project with Jigsaw modules. Maven generates a warning indicating that filename-based automatic modules are detected: [telegrambots-6.9.7.1.jar, telegrambots-meta-6.9.7.1.jar]. The warning strongly advises against publishing this project to a public artifact repository due to the use of automatic modules, which suggests that the telegrambots library lacks explicit module naming. This lack of explicit module naming prevents integration with Jigsaw modules, thereby hindering modularity in applications that utilize this library.
the error: