Conversation
|
@schloerke The internationalization is ready. I've chosen to leave the What's your view on this? |
|
I agree. Let's only change text that You are correct in that we should wait on the question text once we have full page translations. |
|
Nice :) Then, as far as I am concerned, this PR is ready. Let me know if you want me to change anything |
|
Let's get R CMD check to pass, then we can merge. The change above should fix it. IDK why I can't commit it. |
Co-authored-by: Barret Schloerke <[email protected]>
|
Great, everything seems good then :) |
|
This is really great work and will make learnr tutorials more approachable for tutorial authors in general and in other languages! I'd like to propose two additions that would make it easier to change the learnr tutorial language without having to update the learnr package directly (although that should still be encouraged for language translations!).
|
This PR implements a mechanism for internationalizing
{learnr}UI elements.