Skip to content

Fix progressive reveal and Topics with special characters not loading#330

Merged
schloerke merged 4 commits intomasterfrom
progressive_reveal
Feb 12, 2020
Merged

Fix progressive reveal and Topics with special characters not loading#330
schloerke merged 4 commits intomasterfrom
progressive_reveal

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Feb 11, 2020 •
edited
Loading

Fixes #320
Fixes #319

For #320, there was never a call to notify the js data model that the section had actually been skipped.

For #319, the hash was being returned as window.encodeURI output. By passing it through window.decodeURI, it behaves as expected.

File to test with 
---
title: "learnr#330"
output:
  learnr::tutorial:
    progressive: true
    allow_skip: true
runtime: shiny_prerendered
---


## Section 1

### Subtopic 1

text

### Subtopic 2.

text

### Subtopic 3

text

## Säction title

### Subtopic 4

text

### Subtopic 5.

text

### Subtopic 6

text
  • Should be able to click continue and also view the second section.

@schloerke schloerke self-assigned this Feb 11, 2020
@schloerke schloerke requested a review from wch February 12, 2020 15:25
@schloerke schloerke merged commit 6620c67 into master Feb 12, 2020
@schloerke schloerke deleted the progressive_reveal branch February 12, 2020 21:46
schloerke added a commit that referenced this pull request Feb 12, 2020
@schloerke
Merge branch 'master' into v0.10.1-rc
c5abcac 
* master:
  implement tutorial_package_dependencies() (#329)
  Fix progressive reveal and Topics with special characters not loading (#330)
  Remove dead event, clarify Rmd/HTML docs (#331)
  Add session start/stop events (#328)
  Use `.on("load", fn)` as `.load(fn)` has been deprecated (#326)
@schloerke schloerke mentioned this pull request Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wch wch wch approved these changes

Assignees

@schloerke schloerke

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Progressive reveal does not progressively reveal without refresh Umlauts in section titles destroy navigation

2 participants

@schloerke @wch