code review fixes

karthikkondapally · karthikkondapally · commit 031fa64c0d54 · 2018-05-04T23:36:03.000+05:30
diff --git a/util/src/main/java/io/kubernetes/client/util/Yaml.java b/util/src/main/java/io/kubernetes/client/util/Yaml.java
@@ -166,7 +166,7 @@ public static Object load(File f) throws IOException {
    */
   public static Object load(Reader reader) throws IOException {
     Map<String, Object> data = getSnakeYaml().load(reader);
-    return ModelMapper(data);
+    return modelMapper(data);
   }
 
   /**
@@ -251,7 +251,11 @@ public static List<Object> loadAll(Reader reader) throws IOException {
     List<Object> list = new ArrayList<Object>();
     for (Object object : iterable) {
       if (object != null) {
-        list.add(ModelMapper((Map<String, Object>) object));
+        try {
+          list.add(modelMapper((Map<String, Object>) object));
+        } catch (ClassCastException ex) {
+          logger.error("Unexpected exception while casting: " + ex);
+        }
       }
     }
 
@@ -287,7 +291,7 @@ public static org.yaml.snakeyaml.Yaml getSnakeYaml() {
    * @return An instantiation of the object.
    * @throws IOException
    */
-  private static Object ModelMapper(Map<String, Object> data) throws IOException {
+  private static Object modelMapper(Map<String, Object> data) throws IOException {
     String kind = (String) data.get("kind");
     if (kind == null) {
       throw new IOException("Missing kind in YAML file!");
