Fix #12647 Repeated typedef not handled (danmar#6355)

chrchr-github · web-flow · commit fae65de400f6 · 2024-04-27T16:44:33.000+02:00
diff --git a/lib/tokenize.cpp b/lib/tokenize.cpp
@@ -1077,7 +1077,8 @@ void Tokenizer::simplifyTypedef()
 
         if (indentlevel == 0 && tok->str() == "typedef") {
             TypedefSimplifier ts(tok);
-            if (!ts.fail() && numberOfTypedefs[ts.name()] == 1) {
+            if (!ts.fail() && numberOfTypedefs[ts.name()] == 1 &&
+                (numberOfTypedefs.find(ts.getTypedefToken()->strAt(1)) == numberOfTypedefs.end() || ts.getTypedefToken()->strAt(2) == "(")) {
                 if (mSettings.severity.isEnabled(Severity::portability) && ts.isInvalidConstFunctionType(typedefs))
                     reportError(tok->next(), Severity::portability, "invalidConstFunctionType",
                                 "It is unspecified behavior to const qualify a function type.");
diff --git a/test/testgarbage.cpp b/test/testgarbage.cpp
@@ -725,7 +725,7 @@ class TestGarbage : public TestFixture {
     }
 
     void garbageCode63() { // #6739
-        ASSERT_THROW_INTERNAL(checkCode("{ } { } typedef int u_array[]; typedef u_array &u_array_ref; (u_array_ref arg) { } u_array_ref u_array_ref_gbl_obj0"), INTERNAL);
+        ASSERT_THROW_INTERNAL(checkCode("{ } { } typedef int u_array[]; typedef u_array &u_array_ref; (u_array_ref arg) { } u_array_ref u_array_ref_gbl_obj0"), SYNTAX);
     }
 
     void garbageCode64() { // #6740
diff --git a/test/testsimplifytypedef.cpp b/test/testsimplifytypedef.cpp
@@ -216,6 +216,7 @@ class TestSimplifyTypedef : public TestFixture {
         TEST_CASE(simplifyTypedef150);
         TEST_CASE(simplifyTypedef151);
         TEST_CASE(simplifyTypedef152);
+        TEST_CASE(simplifyTypedef153);
 
         TEST_CASE(simplifyTypedefFunction1);
         TEST_CASE(simplifyTypedefFunction2); // ticket #1685
@@ -1226,7 +1227,7 @@ class TestSimplifyTypedef : public TestFixture {
                             "LPCSTR ccp;";
 
         const char expected[] =
-            "char c ; "
+            "; char c ; "
             "char * cp ; "
             "const char * ccp ;";
 
@@ -3563,6 +3564,16 @@ class TestSimplifyTypedef : public TestFixture {
         ASSERT_EQUALS(exp, tok(code));
     }
 
+    void simplifyTypedef153() {
+        const char* code{}, *exp{}; // #12647
+        code = "typedef unsigned long X;\n"
+               "typedef unsigned long X;\n"
+               "typedef X Y;\n"
+               "Y y;\n";
+        exp = "long y ;";
+        ASSERT_EQUALS(exp, tok(code));
+    }
+
     void simplifyTypedefFunction1() {
         {
             const char code[] = "typedef void (*my_func)();\n"

Original file line number	Diff line number	Diff line change
`@@ -725,7 +725,7 @@ class TestGarbage : public TestFixture {`
`725`	`725`	`}`
`726`	`726`
`727`	`727`	`void garbageCode63() { // #6739`
`728`		`- ASSERT_THROW_INTERNAL(checkCode("{ } { } typedef int u_array[]; typedef u_array &u_array_ref; (u_array_ref arg) { } u_array_ref u_array_ref_gbl_obj0"), INTERNAL);`
	`728`	`+ ASSERT_THROW_INTERNAL(checkCode("{ } { } typedef int u_array[]; typedef u_array &u_array_ref; (u_array_ref arg) { } u_array_ref u_array_ref_gbl_obj0"), SYNTAX);`
`729`	`729`	`}`
`730`	`730`
`731`	`731`	`void garbageCode64() { // #6740`