Fix #12455 FP bitwiseOnBoolean [inconclusive] (danmar#6040)

chrchr-github · web-flow · commit 950e894319b8 · 2024-02-26T14:36:24.000+01:00
diff --git a/lib/checkbool.cpp b/lib/checkbool.cpp
@@ -113,6 +113,8 @@ void CheckBool::checkBitwiseOnBoolean()
                     continue;
                 const bool isBoolOp1 = astIsBool(tok->astOperand1());
                 const bool isBoolOp2 = astIsBool(tok->astOperand2());
+                if (!tok->astOperand1()->valueType() || !tok->astOperand2()->valueType())
+                    continue;
                 if (!(isBoolOp1 || isBoolOp2))
                     continue;
                 if (isCompound && (!isBoolOp1 || isBoolOp2))
diff --git a/test/testbool.cpp b/test/testbool.cpp
@@ -954,6 +954,16 @@ class TestBool : public TestFixture {
               "    return b;\n"
               "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        check("struct S { bool b{}; };\n" // #12455
+              "void f(const std::unordered_map<int, S> m) {\n"
+              "    for (const auto& e : m) {\n"
+              "        S s;\n"
+              "        s.b |= e.second.b;\n"
+              "        (void)s.b;\n"
+              "    }\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
     }
 
     void incrementBoolean() {
