Fix #10655 FN bitwiseOnBoolean with unseen function (danmar#4214)

chrchr-github · web-flow · commit 176eefcbf31b · 2022-06-14T23:08:17.000+02:00
diff --git a/lib/checkbool.cpp b/lib/checkbool.cpp
@@ -104,8 +104,7 @@ void CheckBool::checkBitwiseOnBoolean()
                     continue;
                 if (tok->str() == "|" && !isConvertedToBool(tok) && !(astIsBool(tok->astOperand1()) && astIsBool(tok->astOperand2())))
                     continue;
-                if (!isConstExpression(tok->astOperand1(), mSettings->library, true, mTokenizer->isCPP()))
-                    continue;
+                // first operand will always be evaluated
                 if (!isConstExpression(tok->astOperand2(), mSettings->library, true, mTokenizer->isCPP()))
                     continue;
                 if (tok->astOperand2()->variable() && tok->astOperand2()->variable()->nameToken() == tok->astOperand2())
diff --git a/test/testbool.cpp b/test/testbool.cpp
@@ -914,6 +914,24 @@ class TestBool : public TestFixture {
               "    return ((p - xm >= d) << 1) | (x - p > d);\n"
               "}\n");
         ASSERT_EQUALS("", errout.str());
+
+        check("int g();\n" // #10655
+              "void f(bool b) {\n"
+              "    if (g() | b) {}\n"
+              "}\n");
+        ASSERT_EQUALS("[test.cpp:3]: (style, inconclusive) Boolean expression 'b' is used in bitwise operation. Did you mean '||'?\n", errout.str());
+
+        check("int g();\n"
+              "void f(bool b) {\n"
+              "    if (b | g()) {}\n"
+              "}\n");
+        ASSERT_EQUALS("", errout.str());
+
+        check("int g();\n"
+              "bool f(bool b, bool c) {\n"
+              "    return b | g() | c;\n"
+              "}\n");
+        ASSERT_EQUALS("[test.cpp:3]: (style, inconclusive) Boolean expression 'c' is used in bitwise operation. Did you mean '||'?\n", errout.str());
     }
 
     void incrementBoolean() {
