Added tests for PYTHON-890 and PYTHON-877

beltran · beltran · commit ecc32cc40104 · 2018-01-16T13:02:18.000-05:00
diff --git a/tests/integration/cqlengine/model/test_model.py b/tests/integration/cqlengine/model/test_model.py
@@ -224,3 +224,45 @@ def test_comparison(self):
         self.assertLessEqual(TestQueryUpdateModel.partition.column, TestQueryUpdateModel.cluster.column)
         self.assertGreater(TestQueryUpdateModel.cluster.column, TestQueryUpdateModel.partition.column)
         self.assertGreaterEqual(TestQueryUpdateModel.cluster.column, TestQueryUpdateModel.partition.column)
+
+
+class TestDeprecationWarning(unittest.TestCase):
+    def test_deprecation_warnings(self):
+        """
+        Test to some deprecation warning have been added. It tests warnings for
+        negative index, negative index slicing and table sensitive removal
+
+        This test should be removed in 4.0, that's why the imports are in
+        this test, so it's easier to remove
+
+        @since 3.13
+        @jira_ticket PYTHON-877
+        @expected_result the deprecation warnings are emitted
+
+        @test_category logs
+        """
+        import warnings
+
+        class SensitiveModel(Model):
+            __table_name__ = 'SensitiveModel'
+            __table_name_case_sensitive__ = True
+            k = columns.Integer(primary_key=True)
+
+        with warnings.catch_warnings(record=True) as w:
+            warnings.simplefilter("always")
+            sync_table(SensitiveModel)
+            self.addCleanup(drop_table, SensitiveModel)
+
+            SensitiveModel.create(k=0)
+
+            rows = SensitiveModel.objects().all().allow_filtering()
+            rows[-1]
+            rows[-1:]
+
+            self.assertEqual(len(w), 4)
+            self.assertIn("__table_name_case_sensitive__ will be removed in 4.0.", str(w[0].message))
+            self.assertIn("__table_name_case_sensitive__ will be removed in 4.0.", str(w[1].message))
+            self.assertIn("ModelQuerySet indexing with negative indices support will be removed in 4.0.",
+                          str(w[2].message))
+            self.assertIn("ModelQuerySet slicing with negative indices support will be removed in 4.0.",
+                          str(w[3].message))
diff --git a/tests/integration/standard/test_cluster.py b/tests/integration/standard/test_cluster.py
@@ -23,6 +23,7 @@
 import time
 from uuid import uuid4
 import logging
+import warnings
 
 import cassandra
 from cassandra.cluster import Cluster, Session, NoHostAvailable, ExecutionProfile, EXEC_PROFILE_DEFAULT
@@ -45,6 +46,7 @@
 
 def setup_module():
     use_singledc()
+    warnings.simplefilter("always")
 
 
 class IgnoredHostPolicy(RoundRobinPolicy):
@@ -1428,3 +1430,40 @@ def test_valid_protocol_version_beta_options_connect(self):
         self.assertEqual(cluster.protocol_version, cassandra.ProtocolVersion.MAX_SUPPORTED)
         self.assertTrue(session.execute("select release_version from system.local")[0])
         cluster.shutdown()
+
+
+class DeprecationWarningTest(unittest.TestCase):
+    def test_deprecation_warnings_legacy_parameters(self):
+        """
+        Tests the deprecation warning has been added when using
+        legacy parameters
+
+        @since 3.13
+        @jira_ticket PYTHON-877
+        @expected_result the deprecation warning is emitted
+
+        @test_category logs
+        """
+        with warnings.catch_warnings(record=True) as w:
+            Cluster(load_balancing_policy=RoundRobinPolicy())
+            self.assertEqual(len(w), 1)
+            self.assertIn("Legacy execution parameters will be removed in 4.0. Consider using execution profiles.",
+                          str(w[0].message))
+
+    def test_deprecation_warnings_meta_refreshed(self):
+        """
+        Tests the deprecation warning has been added when enabling
+        metadata refreshment
+
+        @since 3.13
+        @jira_ticket PYTHON-890
+        @expected_result the deprecation warning is emitted
+
+        @test_category logs
+        """
+        with warnings.catch_warnings(record=True) as w:
+            cluster = Cluster()
+            cluster.set_meta_refresh_enabled(True)
+            self.assertEqual(len(w), 1)
+            self.assertIn("Cluster.set_meta_refresh_enabled is deprecated and will be removed in 4.0.",
+                          str(w[0].message))
