• fix(rivetkit): stop logging benign actor-sleep aborts at error level #5211 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

🚅 Deployed to the rivet-pr-5211 environment in rivet-frontend

Service	Status	Web	Updated (UTC)
website	😴 Sleeping (View Logs)	Web	Jun 9, 2026 at 5:47 pm
kitchen-sink	❌ Build Failed (View Logs)	Web	Jun 9, 2026 at 5:38 pm
frontend-inspector	❌ Build Failed (View Logs)	Web	Jun 9, 2026 at 5:38 pm
ladle	❌ Build Failed (View Logs)	Web	Jun 9, 2026 at 5:33 pm
frontend-cloud	❌ Build Failed (View Logs)	Web	Jun 9, 2026 at 5:33 pm
mcp-hub	✅ Success (View Logs)	Web	Jun 9, 2026 at 5:32 pm

Code Review

This PR correctly demotes the log level for benign actor-sleep aborts from error to debug. The fix also extracts a reusable isActorAbortedError helper in TypeScript and patches a race condition in the workflow error handler.

What's Good

• Clean abstraction: isActorAbortedError in errors.ts centralises the group/code check and eliminates inline string literals duplicated in native.ts.
• Race condition fix in workflow/mod.ts: Adding the structural error check as a second guard alongside abortSignal.aborted is the right approach.
• Rust logging follows tracing conventions: structured fields, lowercase message, no inline string interpolation.

Issues / Suggestions

1. No tests (important): The checklist item is unchecked and there is no test coverage. A test putting an actor to sleep while a queue handler runs and asserting no error-level log would prevent regression.

2. Empty PR description: The PR body is the unmodified template. A sentence describing what was happening and what the fix does would help reviewers.

3. Rust inlines the check while TypeScript has a helper: napi_actor_events.rs hardcodes the group/code strings directly while TypeScript centralized this in isActorAbortedError. If the error code changes, the Rust side needs a separate update.

4. Debug log omits the error value: The new debug path does not include the error field. Including it would make it easier to confirm the error really is the expected abort.

5. Minor: The comment in errors.ts uses 'parked run handler' which ties the helper to one call site. A more general description would be more durable.

Summary

The core logic is correct and the abstraction is an improvement. The main gaps are the missing test and the empty PR description.