Validate category field before use as dict key in CSR appendix generation#236
Merged
james-ball-qualcomm merged 2 commits intoadd_csr_tablefrom Mar 25, 2026
Merged
Validate category field before use as dict key in CSR appendix generation#236james-ball-qualcomm merged 2 commits intoadd_csr_tablefrom
category field before use as dict key in CSR appendix generation#236james-ball-qualcomm merged 2 commits intoadd_csr_tablefrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: james-ball-qualcomm <[email protected]> Agent-Logs-Url: https://github.com/riscv/docs-resources/sessions/97879fc1-cfcc-4840-9ac8-a85f60aa5b19
james-ball-qualcomm
approved these changes
Mar 25, 2026
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on WARL/WLRL CSR AsciiDoc appendix include files
Validate Mar 25, 2026
category field before use as dict key in CSR appendix generation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
categorywas retrieved from CSR data with a silent""default and used directly as a(csr_dir, category)dict key. An unrecognized, empty, or non-stringcategorywould silently drop CSRs from the WARL/WLRL grouped tables rather than producing a controlled error.Changes
tools/create_csr_appendix.py—write_output_files: replace the unvalidatedcsr.get("category", "")with explicit checks:categoryis missing, empty, or not a stringcategoryis not inIMPLDEF_CATEGORIES, listing allowed values in the error message✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.