Add initial support for AzureDevOps repositories.#15
Merged
rhysd merged 5 commits intorhysd:masterfrom Nov 3, 2019
bgianfo:azdevops-support
Merged
Add initial support for AzureDevOps repositories.#15rhysd merged 5 commits intorhysd:masterfrom bgianfo:azdevops-support
rhysd merged 5 commits intorhysd:masterfrom
bgianfo:azdevops-support
Conversation
bgianfo
commented
Aug 11, 2019
rhysd
requested changes
Aug 12, 2019
Owner
|
@bgianfo Thank you for nice PR! I reviewed the patch and I felt tweaking URL to fit to GitHub-like URLs is hacky. Would you consider to update it? |
Contributor
Author
|
Sorry for the slow response, I'll get around to addressing your feedback. Thanks! |
Owner
|
No problem. Please take your pace. Please ping me when you finish your work. I'll review changes. |
added 5 commits
October 7, 2019 02:34
This change implements basic support for repositories hosted on AzureDevOps (formerly, Visual Studio Team Services). Because there are many people who still use the old legacy URLs, which continue to be supported, I've implemented support for both. This ends up being a matrix of: - http://visualstudio.com - http://dev.azure.com - ssh://vs-ssh.visualstudio.com - ssh://ssh.dev.azure.com I've included tests to validate all of the newly introduced functionality.
Contributor
Author
|
@rhysd I think this is ready for another review, thanks! |
Contributor
Author
|
@rhysd ping |
Owner
|
I'm sorry for long delay since I focused on a few projects (and some private projects). Let me check changes. |
rhysd
approved these changes
Nov 3, 2019
Owner
rhysd
left a comment
rhysd
left a comment
There was a problem hiding this comment.
Looks good! Thank you for the updates.
rhysd
added a commit
that referenced
this pull request
Nov 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change implements basic support for repositories
hosted on AzureDevOps (formerly, Visual Studio Team Services).
Because there are many people who still use the old legacy URLs,
which continue to be supported, I've implemented support for both.
This ends up being a matrix of:
I've included tests to validate all of the newly introduced functionality.