Skip to content

Commit 8e992ed

Browse files
alixhamitseaver
alixhami
authored and
tseaver
committed
Refactor snippets: only delete datasets + contents rather than tables (googleapis#5627)
1 parent d94436d commit 8e992ed

1 file changed

Lines changed: 0 additions & 29 deletions

File tree

‎docs/bigquery/snippets.py‎

Lines changed: 0 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -76,8 +76,6 @@ def to_delete(client):
7676
for item in doomed:
7777
if isinstance(item, (bigquery.Dataset, bigquery.DatasetReference)):
7878
client.delete_dataset(item, delete_contents=True)
79-
elif isinstance(item, (bigquery.Table, bigquery.TableReference)):
80-
client.delete_table(item)
8179
else:
8280
item.delete()
8381

@@ -486,8 +484,6 @@ def test_list_tables(client, to_delete):
486484
assert tables[0].table_id == 'my_table'
487485
# [END bigquery_list_tables]
488486

489-
to_delete.insert(0, table)
490-
491487

492488
def test_create_table(client, to_delete):
493489
"""Create a table."""
@@ -513,8 +509,6 @@ def test_create_table(client, to_delete):
513509
assert table.table_id == 'my_table'
514510
# [END bigquery_create_table]
515511

516-
to_delete.insert(0, table)
517-
518512

519513
@pytest.mark.skip(reason=(
520514
'update_table() is flaky '
@@ -538,9 +532,6 @@ def test_create_table_then_add_schema(client, to_delete):
538532

539533
assert table.table_id == 'my_table'
540534
# [END bigquery_create_table_without_schema]
541-
542-
to_delete.insert(0, table)
543-
544535
# [START bigquery_add_schema_to_empty]
545536
# from google.cloud import bigquery
546537
# client = bigquery.Client()
@@ -748,7 +739,6 @@ def test_get_table_information(client, to_delete):
748739
table = bigquery.Table(dataset.table(table_id), schema=SCHEMA)
749740
table.description = ORIGINAL_DESCRIPTION
750741
table = client.create_table(table)
751-
to_delete.insert(0, table)
752742

753743
# [START bigquery_get_table]
754744
# from google.cloud import bigquery
@@ -805,7 +795,6 @@ def test_table_exists(client, to_delete):
805795
table_ref = dataset.table(TABLE_ID)
806796
table = bigquery.Table(table_ref, schema=SCHEMA)
807797
table = client.create_table(table)
808-
to_delete.insert(0, table)
809798

810799
assert table_exists(client, table_ref)
811800
assert not table_exists(client, dataset.table('i_dont_exist'))
@@ -823,7 +812,6 @@ def test_manage_table_labels(client, to_delete):
823812

824813
table = bigquery.Table(dataset.table(table_id), schema=SCHEMA)
825814
table = client.create_table(table)
826-
to_delete.insert(0, table)
827815

828816
# [START bigquery_label_table]
829817
# from google.cloud import bigquery
@@ -892,7 +880,6 @@ def test_update_table_description(client, to_delete):
892880
table = bigquery.Table(dataset.table(table_id), schema=SCHEMA)
893881
table.description = 'Original description.'
894882
table = client.create_table(table)
895-
to_delete.insert(0, table)
896883

897884
# [START bigquery_update_table_description]
898885
# from google.cloud import bigquery
@@ -922,7 +909,6 @@ def test_update_table_expiration(client, to_delete):
922909

923910
table = bigquery.Table(dataset.table(table_id), schema=SCHEMA)
924911
table = client.create_table(table)
925-
to_delete.insert(0, table)
926912

927913
# [START bigquery_update_table_expiration]
928914
import datetime
@@ -959,7 +945,6 @@ def test_add_empty_column(client, to_delete):
959945

960946
table = bigquery.Table(dataset.table(table_id), schema=SCHEMA)
961947
table = client.create_table(table)
962-
to_delete.insert(0, table)
963948

964949
# [START bigquery_add_empty_column]
965950
# from google.cloud import bigquery
@@ -1019,8 +1004,6 @@ def test_relax_column(client, to_delete):
10191004
assert all(field.mode == 'NULLABLE' for field in table.schema)
10201005
# [END bigquery_relax_column]
10211006

1022-
to_delete.insert(0, table)
1023-
10241007

10251008
@pytest.mark.skip(reason=(
10261009
'update_table() is flaky '
@@ -1040,7 +1023,6 @@ def test_update_table_cmek(client, to_delete):
10401023
table.encryption_configuration = bigquery.EncryptionConfiguration(
10411024
kms_key_name=original_kms_key_name)
10421025
table = client.create_table(table)
1043-
to_delete.insert(0, table)
10441026

10451027
# [START bigquery_update_table_cmek]
10461028
# from google.cloud import bigquery
@@ -1239,7 +1221,6 @@ def test_table_insert_rows(client, to_delete):
12391221

12401222
table = bigquery.Table(dataset.table(table_id), schema=SCHEMA)
12411223
table = client.create_table(table)
1242-
to_delete.insert(0, table)
12431224

12441225
# [START bigquery_table_insert_rows]
12451226
# from google.cloud import bigquery
@@ -1296,7 +1277,6 @@ def test_load_table_from_file(client, to_delete):
12961277
# [END bigquery_load_from_file]
12971278

12981279
table = client.get_table(table_ref)
1299-
to_delete.insert(0, table)
13001280
rows = list(client.list_rows(table)) # API request
13011281

13021282
assert len(rows) == 2
@@ -1926,8 +1906,6 @@ def test_copy_table(client, to_delete):
19261906
assert dest_table.num_rows > 0
19271907
# [END bigquery_copy_table]
19281908

1929-
to_delete.insert(0, dest_table)
1930-
19311909

19321910
def test_copy_table_multiple_source(client, to_delete):
19331911
dest_dataset_id = 'dest_dataset_{}'.format(_millis())
@@ -1950,8 +1928,6 @@ def test_copy_table_multiple_source(client, to_delete):
19501928
table_data = {'table1': b'Washington,WA', 'table2': b'California,CA'}
19511929
for table_id, data in table_data.items():
19521930
table_ref = source_dataset.table(table_id)
1953-
table = bigquery.Table(table_ref, schema=schema)
1954-
to_delete.insert(0, table)
19551931
job_config = bigquery.LoadJobConfig()
19561932
job_config.schema = schema
19571933
body = six.BytesIO(data)
@@ -1985,7 +1961,6 @@ def test_copy_table_multiple_source(client, to_delete):
19851961
# [END bigquery_copy_table_multiple_source]
19861962

19871963
assert dest_table.num_rows == 2
1988-
to_delete.insert(0, dest_table)
19891964

19901965

19911966
def test_copy_table_cmek(client, to_delete):
@@ -2029,8 +2004,6 @@ def test_copy_table_cmek(client, to_delete):
20292004
assert dest_table.encryption_configuration.kms_key_name == kms_key_name
20302005
# [END bigquery_copy_table_cmek]
20312006

2032-
to_delete.insert(0, dest_table)
2033-
20342007

20352008
def test_extract_table(client, to_delete):
20362009
from google.cloud import storage
@@ -2276,7 +2249,6 @@ def test_client_query_destination_table(client, to_delete):
22762249
dataset = bigquery.Dataset(dataset_ref)
22772250
dataset.location = 'US'
22782251
client.create_dataset(dataset)
2279-
to_delete.insert(0, dataset_ref.table('your_table_id'))
22802252

22812253
# [START bigquery_query_destination_table]
22822254
# from google.cloud import bigquery
@@ -2352,7 +2324,6 @@ def test_client_query_destination_table_cmek(client, to_delete):
23522324
dataset = bigquery.Dataset(dataset_ref)
23532325
dataset.location = 'US'
23542326
client.create_dataset(dataset)
2355-
to_delete.insert(0, dataset_ref.table('your_table_id'))
23562327

23572328
# [START bigquery_query_destination_table_cmek]
23582329
# from google.cloud import bigquery

0 commit comments

Comments
 (0)