Use plain Jackson to get effectively the same deserialization results.#9
Merged
NotJustAnna merged 2 commits intomasterfrom Feb 14, 2020
Merged
Use plain Jackson to get effectively the same deserialization results.#9NotJustAnna merged 2 commits intomasterfrom
NotJustAnna merged 2 commits intomasterfrom
Conversation
Member
Author
|
Implemented a fix for #2 which is in the same method, so I appended it here. |
Contributor
|
Does "effectively" the same deserialization results mean different results? If so, when? |
Member
Author
It should not generate different results, but this account for cases the previous method doesn't cover. Example code: public class User {
private String name;
private LoginToken loginToken;
public LoginToken getLoginToken() { return loginToken; } // this is a getter
public void setLoginToken(LoginToken loginToken) { this.loginToken = loginToken; } // this is a setter
public static class LoginToken {
private String b64;
public String getB64() { return b64; }
public void setB64(String b64) { this.b64 = b64; }
}
}Example serialized JSON: Example cases:
All previous code and serializations that already worked would keep working. |
gabor-boros
approved these changes
Feb 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jackson has a built-in feature which makes this irrelevant. The plain ObjectMapper can be used if an DeserializationFeature is disabled.