Merged
Conversation
Member
Author
|
|
added 2 commits
February 14, 2020 19:14
…com/rethinkdb/rethinkdb-java into develop/experimental � Conflicts: � Makefile � build.gradle � src/main/java/com/rethinkdb/RethinkDB.java � src/main/java/com/rethinkdb/net/Util.java
Member
Author
|
Reactive streams was dropped due to their |
This was referenced Feb 15, 2020
Closed
Member
Author
|
rethinkdb/rethinkdb#4101 implemented on commits |
added 5 commits
February 17, 2020 17:19
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tracks experimental changes for the official rethinkdb-java driver.
Implemented changes
json-simplewith Jacksonjava.util.Optionalusage with@NullableannotationsUtil.toReqlAst()wrongly resetting the remaining depth.TypeReference<T>onReqlAst.run()ReqlAst.runAsync(): Asynchronous resultReqlAst.toString()pretty-prints the ASTMapObjectDefaultConnectionFactoryConnection.noreplyWaitAsync(): Asynchronous noreplyWaitConnection.server()and async variance (Implements Add server_info() command #14)Cursorwas deleted and replaced withResultReqlAsr.run()always returnsResult<T>, which covers all result types and implementsIterator<T>andIterable<T>toList(),collect(),stream(),parallelStream()methodsResult<List<T>>is unwrapped toResult<T>)r.pathspec(...)(Implements Implement r.pathspec(...) #16)Util.toReqlAst()now properly serializes primitive arrays and other Collections as well.Partially implemented
CoerceTypeNotes
Code which use Connection, Cursor and the old dynamic return type of
.runbreaks, but those classes got full documentation of the new usage.All tests doesn't compile. Root tests may need manual rewrite while Generated tests need Python scripts need rewrite to generate new valid tests.Tests now compile by patching TestingCommon to generate expected behaviour.