Makes heartbeat more tolerant to failures. #1884
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@PatrickTulskie any chance of getting this reviewed? |
Contributor
|
@arianf sure thing. I just gave it a quick pass, but it doesn't look like there were any added tests. Also I don't really know this area of the code super well so I might need some time to digest all of this. In the mean time, mind adding some tests for your changes? |
iloveitaly
reviewed
Nov 6, 2023
|
|
||
| loop do | ||
| break if shutdown? | ||
| start_heartbeat if !heartbeat_alive? |
Contributor
There was a problem hiding this comment.
could we document inline exactly what this is protecting against?
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes heartbeat more tolerant to failures.
Closes #1883
Unsure if I should also be cleaning up
@@all_heartbeat_threadsif we detect a dead heartbeat.