[ENGG-4237]: Add Deletion Modal & Analytics Events to Local Workspace Deletion #3968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ajinkya-browserstack
changed the title
nafees87n
approved these changes
Dec 5, 2025
Comment on lines
28
to
29
| export const trackWorkspaceDeleted = (params) => { | ||
| trackEvent(TEAMS.WORKSPACE_DELETED, params); |
Contributor
There was a problem hiding this comment.
use the exact params here in the args because its a js file. The consumers won't be able to know what params to pass. If we are clear about it in the args then it would be clear to the consumer
Contributor
Author
There was a problem hiding this comment.
Changes committed.
…stly into engg-4237-deletion-modal
nafees87n
reviewed
Dec 5, 2025
Co-authored-by: Nafees Nehar <[email protected]>
ajinkya-browserstack
merged commit f758039
into
engg-4237-support-to-delete-workspaces
3 checks passed
ajinkya-browserstack
added a commit
that referenced
this pull request
Dec 5, 2025
* fix: Fix active workspace name * fix: Fix dependency array for activeWorkspaceName, code cleanup * [WIP] feat: Add Delete functionality for local workspaces * fix: Apply CodeRabbit suggestion to avoid rendering until teamDetails is valid * refactor: Move local workspace deletion code to a separate component * refactor: Remove previousPath typecasting as per PR suggestion * refactor: Change variable name as per PR suggestion * refactor/fix: Replace window.state with useSelector to access Redux state * change: Change removeWorkspace timeout from 80s to 10s * refactor: Use WorkspaceType.LOCAL instead of string literal * refactor: Move refresh and navigation code in DeleteWorkspaceSection to a separate function * refactor/fix: Change type for removeWorkspace to FileSystemResult<void> * refactor: Rename DeleteWorkspaceSection to DeleteLocalWorkspaceSection * refactor: Use existing type FileSystemResult and remove newly declared types for removeWorkspace * refactor: Remove optional chaining from getNonLocalWorkspaces * refactor: Use getAllWorkspaces() as getAllLocalWorkspaces() in DeleteWorkspaceSection * refactor: Rename local workspace deletion component and move styling to a separate file * change: Move toast after setAllWorkspaces dispatch * refactor: Switch to useParams to get workspaceId * refactor: Use WorkspaceType.LOCAL instead of string literal * change: Add Sentry captureException to addWorkspaceToView * refactor/fix: Remove redundant FileSystemError type from FsManagerServiceAdapter * refactor: Refactor Sentry captureException * refactor: Revert successful workspace deletion toast position & add a toast to indicate refresh failure * fix: Check result type for removeWorkspace * refactor: Remove comment for removeWorkspace * refactor: Move DeleteLocalWorkspaceSection files to a separate folder * feat: Add compatibility check for DeleteLocalWorkspace * fix: workspace selectors * [ENGG-4237]: Add Deletion Modal & Analytics Events to Local Workspace Deletion (#3968) * add: Add Deletion Modal for local workspace deletion * add: Add analytics tracking for workspaceDeleteClicked and workspaceDeleted * refactor: Specify exact params for trackWorkspaceDeleted * Update app/src/modules/analytics/events/common/teams/index.js Co-authored-by: Nafees Nehar <[email protected]> --------- Co-authored-by: Nafees Nehar <[email protected]> --------- Co-authored-by: nafees87n <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue:
📜 Summary of changes:
🎥 Demo Video:
Video/Demo:
✅ Checklist:
🧪 Test instructions:
🔗 Other references: