Skip to content

[ENGG-4607] Enable autoFocus for Environment Creation #3786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ajinkya-browserstack merged 10 commits into from
Nov 3, 2025
Merged

[ENGG-4607] Enable autoFocus for Environment Creation #3786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
b9ba801
fix: Enable breadcrumb autofocus on creation of a new Collection
ajinkya-browserstack Oct 30, 2025
5137c36
refactor: rename CollectionView prop isNewItem to isNewRecord
ajinkya-browserstack Oct 30, 2025
6147822
fix: Add isNew, setIsNew to tabStore, change getIsNew() to use tabSto…
ajinkya-browserstack Oct 30, 2025
ca40ec2
Apply suggestions from code review (coderabbitai)
ajinkya-browserstack Oct 31, 2025
3a6911f
Merge branch 'master' into ENGG-4606-autofocus-breadcrumb
nafees87n Oct 31, 2025
dba7497
Update app/src/componentsV2/Tabs/store/tabStore.ts, suggestion by Nafees
ajinkya-browserstack Oct 31, 2025
c2d2d33
fix: Move setIsNew(false) to onBlur
ajinkya-browserstack Oct 31, 2025
0f8fcb7
fix: Enable autoFocus for Environment creation
ajinkya-browserstack Oct 31, 2025
e5760b7
fix: Add setIsNew(false) to environment (VariablesListHeader) header …
ajinkya-browserstack Oct 31, 2025
b73f030
Merge branch 'master' of github.com:requestly/requestly into ENGG-460…
ajinkya-browserstack Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/features/apiClient/contexts/apiClient.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ export const ApiClientProvider: React.FC<ApiClientProviderProps> = ({ children }
new EnvironmentViewTabSource({
id: newEnvironment.id,
title: newEnvironment.name,
focusBreadcrumb: true,
isNewTab: true,
context: {
id: context.id,
},
Expand Down
7 changes: 5 additions & 2 deletions ...ures/apiClient/screens/environment/components/VariablesListHeader/VariablesListHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export const VariablesListHeader: React.FC<VariablesListHeaderProps> = ({
const {
env: { renameEnvironment },
} = useCommand();
const { setTitle, getIsActive, getIsNew } = useGenericState();
const { setTitle, getIsActive, getIsNew, setIsNew } = useGenericState();
const enableHotKey = getIsActive();
const isNewEnvironment = getIsNew();

Expand All @@ -67,7 +67,10 @@ export const VariablesListHeader: React.FC<VariablesListHeaderProps> = ({
autoFocus={isNewEnvironment}
placeholder="New Environment"
recordName={currentEnvironmentName}
onBlur={handleNewEnvironmentNameChange}
onBlur={(newName) => {
handleNewEnvironmentNameChange(newName);
setIsNew(false);
}}
disabled={isGlobalEnvironment(environmentId)}
defaultBreadcrumbs={[
{ label: "API Client", pathname: PATHS.API_CLIENT.INDEX },
Expand Down
4 changes: 1 addition & 3 deletions ...res/apiClient/screens/environment/components/environmentView/EnvironmentViewTabSource.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ import { MdHorizontalSplit } from "@react-icons/all-files/md/MdHorizontalSplit";
import { getApiClientEnvironmentsStore } from "features/apiClient/commands/store.utils";
import { ApiClientFeatureContext } from "features/apiClient/store/apiClientFeatureContext/apiClientFeatureContext.store";

interface EnvironmentViewTabSourceMetadata extends TabSourceMetadata {
focusBreadcrumb?: boolean;
}
interface EnvironmentViewTabSourceMetadata extends TabSourceMetadata {}

export class EnvironmentViewTabSource extends BaseTabSource {
constructor(metadata: EnvironmentViewTabSourceMetadata) {
Expand Down