Alterations for failing CI tests#2923
Merged
simov merged 2 commits intorequest:masterfrom May 2, 2018
Merged
Conversation
Member
|
Thanks @gareth-robinson 👍 |
Merged
This was referenced Mar 16, 2021
sabaoongfx
pushed a commit
to sabaoongfx/request-modern
that referenced
this pull request
Mar 10, 2026
Alterations for failing CI tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist:
npm testlocally and all tests are passing.PR Description
This is a suggestion of alterations to test-headers.js to unblock CI again, given there are a number of consistently failing tests there for some months now.
I've changed the invalid header characters test, so that it passes with either the old or new message returned by node.
I've altered the IPv6 header test, so that if the underlying OS doesn't support IPv6 the test doesn't run.
Fixes: #2877