Skip to content

add bigint support to msgpack codec #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jackyzha0 merged 3 commits into from
Sep 3, 2025
Merged

add bigint support to msgpack codec #341

jackyzha0 merged 3 commits into from
Sep 3, 2025

Conversation

@jackyzha0
Copy link
Member

@jackyzha0 jackyzha0 commented Sep 3, 2025 •
edited
Loading

Why

we are seeing failed to send message: Unrecognized object: [object BigInt] in production

from msgpack docs:

This library does not handle BigInt by default, but you have two options to handle it:

1. Set useBigInt64: true to map bigint to MessagePack's int64/uint64
2. Define a custom ExtensionCodec to map bigint to a MessagePack's extension type

What changed

  • do option 2 of the above for binary codec
  • add custom extension for json codec

Versioning

  • Breaking protocol change
  • Breaking ts/js API change

@jackyzha0 jackyzha0 marked this pull request as ready for review September 3, 2025 21:55
@jackyzha0 jackyzha0 requested a review from a team as a code owner September 3, 2025 21:55
@jackyzha0 jackyzha0 requested review from daweifeng-replit and removed request for a team September 3, 2025 21:55
graphite-app[bot]
graphite-app bot reviewed Sep 3, 2025
View reviewed changes
daweifeng-replit
daweifeng-replit approved these changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@daweifeng-replit daweifeng-replit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jackyzha0 jackyzha0 merged commit 625d0ce into main Sep 3, 2025
8 checks passed
@jackyzha0 jackyzha0 deleted the jackyzha0/msgpack-bigint branch September 3, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graphite-app graphite-app[bot] graphite-app[bot] left review comments

@daweifeng-replit daweifeng-replit daweifeng-replit approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jackyzha0 @daweifeng-replit