Skip to content

Commit 3cf2005

Browse files
gkalpakAndrewKushnir
authored andcommitted
build: add ngcc as a valid commit message scope (angular#32144)
PR Close angular#32144
1 parent 2e4d17f commit 3cf2005

3 files changed

Lines changed: 4 additions & 1 deletion

File tree

CONTRIBUTING.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -233,6 +233,7 @@ There are currently a few exceptions to the "use package name" rule:
233233
* **docs-infra**: used for docs-app (angular.io) related changes within the /aio directory of the
234234
repo
235235
* **ivy**: used for changes to the [Ivy renderer](https://github.com/angular/angular/issues/21706).
236+
* **ngcc**: used for changes to the [Angular Compatibility Compiler](./packages/compiler-cli/ngcc/README.md)
236237
* none/empty string: useful for `style`, `test` and `refactor` changes that are done across all
237238
packages (e.g. `style: add missing semicolons`) and for docs changes that are not related to a
238239
specific package (e.g. `docs: fix typo in tutorial`).

docs/TRIAGE_AND_LABELS.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ The owner of the component is then responsible for the secondary / component-lev
1212
The caretaker should be able to determine which component the issue belongs to.
1313
The components have a clear piece of source code associated with it within the `/packages/` folder of this repo.
1414

15-
* `comp: docs-infra` - the angular.io application and docs-related tooling
1615
* `comp: animations`
1716
* `comp: bazel` - @angular/bazel rules
1817
* `comp: benchpress`
@@ -21,6 +20,8 @@ The components have a clear piece of source code associated with it within the `
2120
* `comp: core & compiler` - because core, compiler, compiler-cli and
2221
browser-platforms are very intertwined, we will be treating them as one
2322
* `comp: ivy` - a subset of core representing the new Ivy renderer.
23+
* `comp: ngcc` - a subset of ivy representing the [Angular Compatibility Compiler](../packages/compiler-cli/ngcc/README.md)
24+
* `comp: docs-infra` - the angular.io application and docs-related tooling
2425
* `comp: elements`
2526
* `comp: forms`
2627
* `comp: http`

tools/validate-commit-message/commit-message.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
"http",
2828
"ivy",
2929
"language-service",
30+
"ngcc",
3031
"platform-browser",
3132
"platform-browser-dynamic",
3233
"platform-server",

0 commit comments

Comments
 (0)