reactions-avatars, small-user-avatars - Fix Copilot user#8866
Merged
fregante merged 14 commits intorefined-github:mainfrom Jan 18, 2026
Merged
reactions-avatars, small-user-avatars - Fix Copilot user#8866fregante merged 14 commits intorefined-github:mainfrom
reactions-avatars, small-user-avatars - Fix Copilot user#8866fregante merged 14 commits intorefined-github:mainfrom
Conversation
SunsetTechuila
changed the title
fregante
reviewed
Jan 12, 2026
This reverts commit 866833f.
SunsetTechuila
commented
Jan 13, 2026
| } | ||
|
|
||
| // If it's not a bot, use a shortcut URL #2125 | ||
| if (cleanName === username) { |
Member
Author
There was a problem hiding this comment.
It's technically possible for bots to have a name/avatar different from the user or organization that registered them, so https://avatars.githubusercontent.com/${cleanName} won't work in those cases. Still, I consider that scenario rare enough for bots that leave reactions (I couldn't find any examples) that it's probably not worth accounting for it
SunsetTechuila
commented
Jan 13, 2026
SunsetTechuila
changed the title
fregante
reviewed
Jan 17, 2026
fregante
changed the title
reactions-avatars, small-user-avatars - Fix Copilot user
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #8864
Test URLs
#7761
aio-libs/aiohttp#3809 (comment)
#8848 (comment)
Screenshot